Add dedicated product name to OCP\Defaults #25950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
rullzer,
nickvergessen,
ChristophWurst and
skjnldsv
skjnldsv
reviewed
Mar 5, 2021
| @@ -106,14 +106,24 @@ public function getDocBaseUrl() { | |||
| } | |||
|
|
|||
| /** | |||
| * name of your ownCloud instance | |||
skjnldsv
approved these changes
Mar 5, 2021
ChristophWurst
approved these changes
Mar 5, 2021
|
CI says no |
blizzz
added
the
4. to release
|
CI is unhappy and assets have to be rebuild |
Signed-off-by: Julius Härtl <[email protected]>
…stance name Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
enh/product-name
branch
from
19a7e05 to
d9dd31b
Compare
|
Fix for a regression of this PR is in #27529 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some discrepancies between the public interface (where the name was considered to be the instance name) in contrast to the legacy OC_Defaults backend where it was used as the software name. In regular cases we should always be able to have a dedicated instance name (e.g. MyPersonalCloud) while keeping Nextcloud as a product name so this PR adds a separate method to obtain the product name as a separate label.
For branding scenarios the product name can be changed by using either a custom theme or a theming app config value, though not to publicly exposed as for most setups just saying Nextcloud there would be fine.
In addition to the new method I tried to adapt the usages that I've found referring to the software name.