Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] Catch throwable instead of exception #25013

Merged
merged 1 commit into from
Jan 7, 2021
Merged

[stable20] Catch throwable instead of exception #25013

merged 1 commit into from
Jan 7, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #25011

@rullzer @backportbot
Catch throwable instead of exception
cb958df 
The error that gets thrown can also be a type error etc. So we should
properly catch the Throwable.

Signed-off-by: Roeland Jago Douma <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.5 milestone Jan 7, 2021
@blizzz blizzz merged commit b2cfd43 into stable20 Jan 7, 2021
@blizzz blizzz deleted the backport/25011/stable20 branch January 7, 2021 17:14
@rullzer rullzer mentioned this pull request Jan 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Nextcloud 20.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@rullzer @blizzz