Fix column name to check prior to deleting #25001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
bug
3. to review
|
/backport to stable20 |
1 task
rullzer
approved these changes
Jan 7, 2021
juliusknorr
approved these changes
Jan 7, 2021
juliusknorr
added
4. to release
|
@PVince81 you commented |
|
When I tested this back then locally, it broke the update because the key needs to be updated before we delete the column. I didn't see any mention of testing above, so it's likely that the OC->NC upgrade is now broken. I've posted the diff in the ticket now: #24813 (comment) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #23044 (comment)