Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the user language when adding the footer #24999

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

juliusknorr
Copy link
Member

  • Create a new user and set the language to something different than the default
  • See that the footer of the welcome email is not in the expected user language

@juliusknorr
Copy link
Member Author

/backport to stable20

@rullzer rullzer mentioned this pull request Jan 7, 2021
5 tasks
@rullzer
Copy link
Member

rullzer commented Jan 7, 2021

Conflicts!

@juliusknorr juliusknorr force-pushed the bugfix/noid/email-footer-language branch from 04aebdd to 1dc8bba Compare January 7, 2021 14:29
@juliusknorr juliusknorr force-pushed the bugfix/noid/email-footer-language branch from 1dc8bba to 068e3b2 Compare January 7, 2021 14:32
@faily-bot
Copy link

faily-bot bot commented Jan 7, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1109: failure

mariadb10.1-php7.3

Show full log
There was 1 failure:

1) Test\Files\Cache\Wrapper\CachePermissionsMaskTest::testWithNormalizer
Failed asserting that 0 is greater than 0.

/drone/src/tests/lib/Files/Cache/CacheTest.php:593

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log
  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

@rullzer rullzer merged commit 5020c73 into master Jan 7, 2021
@rullzer rullzer deleted the bugfix/noid/email-footer-language branch January 7, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants