FeaturePolicy => PermissionPolicy #23825

rullzer · 2020-11-01T11:04:22Z

We already had the FeaturePolicy header. However this call got renamed
to PermisionPolicy. Here we move this over. The old mechanism stays
there it just won't get extended. So apps that use the FeaturePolicy
will not stop to work.

Signed-off-by: Roeland Jago Douma [email protected]

Fixes #22792

faily-bot · 2020-11-19T15:40:50Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35702: failure

checkers

I'm a little sad 🤖 and was not able to find the logs for this failed job - please improve me at https://github.com/MorrisJobke/drone-logs to provide this to you

nodb

Show full log

There were 26 warnings:

1) Test\AppFramework\Controller\AuthPublicShareControllerTest::testAuthenticateAuthenticated
Trying to configure method "isAuthenticated" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) OCA\DAV\Tests\unit\CalDAV\CalendarTest::testConfidentialClassification with data set #0 (3, false)
No method rule is set

3) OCA\DAV\Tests\Command\MoveCalendarTest::testMove
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

4) OCA\DAV\Tests\unit\BackgroundJob\UpdateCalendarResourcesRoomsBackgroundJobTest::testRun
Passing an array of interface names to createMock() for creating a test double that implements multiple interfaces is deprecated and will no longer be supported in PHPUnit 9.
Passing an array of interface names to getMockBuilder() for creating a test double that implements multiple interfaces is deprecated and will no longer be supported in PHPUnit 9.

5) ExpirationTest::testParseRetentionObligation with data set #0 ('disabled', null, null, null)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

6) ExpirationTest::testParseRetentionObligation with data set #1 ('auto', 30, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

7) ExpirationTest::testParseRetentionObligation with data set #2 ('auto,auto', 30, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

8) ExpirationTest::testParseRetentionObligation with data set #3 ('auto, auto', 30, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

9) ExpirationTest::testParseRetentionObligation with data set #4 ('auto, 3', -1, 3, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

10) ExpirationTest::testParseRetentionObligation with data set #5 ('5, auto', 5, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

11) ExpirationTest::testParseRetentionObligation with data set #6 ('3, 5', 3, 5, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

12) ExpirationTest::testParseRetentionObligation with data set #7 ('10, 3', 10, 10, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

13) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #0 ('disabled', null, null, null)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

14) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #1 ('auto', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

15) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #2 ('auto,auto', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

16) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #3 ('auto, auto', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

17) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #4 ('auto, 3', -1, 3, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

18) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #5 ('5, auto', 5, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

19) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #6 ('3, 5', 3, 5, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

20) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #7 ('10, 3', 10, 10, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

21) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #8 ('g,a,r,b,a,g,e', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

22) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #9 ('-3,8', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

23) OCA\Settings\Tests\Mailer\NewUserMailHelperTest::testGenerateTemplateWithPasswordResetToken
Method getTime may not return value of type string, its return declaration is ": int"

24) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent
Method publish may not return value of type Mock_IEvent_34632f90, its return declaration is ": void"

25) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_082bcbb5, its return declaration is ": void"

26) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_082bcbb5, its return declaration is ": void"

--

There were 3 failures:

1) Test\AppFramework\Controller\ControllerTest::testFormatDataResponseJSON
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
     'Cache-Control' => 'no-cache, no-store, must-revalidate'
     'Content-Type' => 'application/json; charset=utf-8'
     'Content-Security-Policy' => 'default-src 'none';base-uri '...'none''
-    'Feature-Policy' => 'autoplay 'none';camera 'none'...'none''
     'X-Robots-Tag' => 'none'
+    'Permissions-Policy' => 'autoplay=() camera=() fullscr...ent=()'
 )

/drone/src/tests/lib/AppFramework/Controller/ControllerTest.php:125

2) Test\AppFramework\Http\DataResponseTest::testConstructorAllowsToSetHeaders
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'Cache-Control' => 'no-cache, no-store, must-revalidate'
     'Content-Security-Policy' => 'default-src 'none';base-uri '...'none''
-    'Feature-Policy' => 'autoplay 'none';camera 'none'...'none''
     'X-Robots-Tag' => 'none'
     'test' => 'something'
+    'Permissions-Policy' => 'autoplay=() camera=() fullscr...ent=()'
 )

/drone/src/tests/lib/AppFramework/Http/DataResponseTest.php:76

3) Test\AppFramework\Http\ResponseTest::testSetHeaders
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
     'Something-Else' => 'hi'
     'X-Robots-Tag' => 'none'
     'Content-Security-Policy' => 'default-src 'none';base-uri '...'none''
-    'Feature-Policy' => 'autoplay 'none';camera 'none'...'none''
+    'Permissions-Policy' => 'autoplay=() camera=() fullscr...ent=()'
 )

/drone/src/tests/lib/AppFramework/Http/ResponseTest.php:63

MorrisJobke · 2021-05-20T10:25:46Z

cc @LukasReschke

🏓

We already had the FeaturePolicy header. However this call got renamed to PermisionPolicy. Here we move this over. The old mechanism stays there it just won't get extended. So apps that use the FeaturePolicy will not stop to work. Signed-off-by: Roeland Jago Douma <[email protected]>

Signed-off-by: Daniel Kesselberg <[email protected]>

kesselb · 2023-05-30T20:10:35Z

Rebased the branch.
Replaced 21 with 28.
Fixed the namespace for AddPermissionsPolicyEvent.

solracsf · 2023-06-04T20:46:58Z

CI is red 🔴

MichaIng · 2023-06-05T10:06:27Z

lib/public/AppFramework/Http/FeaturePolicy.php

@@ -35,6 +35,7 @@
 * should require no modification at all for most use-cases.
 *
 * @since 17.0.0
+ * @depreacted 21.0.0 use \OCP\AppFramework\Http\PermissionPolicy


Suggested change

* @depreacted 21.0.0 use \OCP\AppFramework\Http\PermissionPolicy

* @deprecated 28.0.0 use \OCP\AppFramework\Http\PermissionPolicy

That typo appears a few more times.

MichaIng · 2023-06-05T10:06:46Z

lib/public/AppFramework/Http/PermissionPolicy.php

+ * notice that Nextcloud ships already with sensible defaults and those policies
+ * should require no modification at all for most use-cases.
+ *
+ * @since 21.0.0


Suggested change

* @since 21.0.0

* @since 28.0.0

MichaIng · 2023-06-05T10:08:43Z

lib/public/AppFramework/Http/Response.php

+	/**
+	 * @since 17.0.0
+	 * @depreacted 28.0.0 Use setPermissionPolicy
+	 */


Suggested change

/**

* @since 17.0.0

* @depreacted 28.0.0 Use setPermissionPolicy

*/

/**

* @since 28.0.0

*/

skjnldsv · 2024-02-27T13:16:26Z

As there is no feedback since a while I will close this ticket.
If you will decide to work on this feature again and if it hasn't been fixed or implemented already, feel free to re-open and solve the various conflicts.

rullzer added enhancement 2. developing Work in progress labels Nov 1, 2020

rullzer added this to the Nextcloud 21 milestone Nov 1, 2020

rullzer force-pushed the enh/permission_policy branch from 9123d20 to 3a935c7 Compare November 1, 2020 11:04

rullzer force-pushed the enh/permission_policy branch 3 times, most recently from acbb930 to f65ce54 Compare November 19, 2020 14:51

rullzer mentioned this pull request Dec 14, 2020

21 beta2 #24685

Merged

59 tasks

rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Dec 15, 2020

J0WI mentioned this pull request Apr 28, 2021

Set anti-FLoC server header #26539

Closed

MorrisJobke mentioned this pull request May 20, 2021

22 beta1 #26953

Merged

MorrisJobke mentioned this pull request May 26, 2021

22.0.0 beta 2 #27111

Merged

98 tasks

blizzz mentioned this pull request Jun 2, 2021

22.0.0 beta 3 #27342

Merged

57 tasks

skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 Jun 2, 2021

MichaIng mentioned this pull request Jun 6, 2021

Block Federated Learning of Cohorts (FLoC) #27192

Closed

skjnldsv requested a review from LukasReschke July 6, 2021 07:59

skjnldsv mentioned this pull request Oct 13, 2021

23.0.0 beta 1 #29202

Merged

skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 21, 2021

tohn mentioned this pull request Feb 19, 2022

Feature-Policy should be called Permissions-Policy now, having a bit different syntax #22792

Open

skjnldsv mentioned this pull request Mar 24, 2022

24.0.0 beta 1 #31693

Merged

blizzz mentioned this pull request Mar 31, 2022

24.0.0 beta 2 #31769

Merged

This was referenced Apr 7, 2022

24.0.0 beta 3 #31871

Merged

24.0.0 RC1 #31962

Merged

blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022

This was referenced May 3, 2023

27.0.0 beta 1 #38038

Merged

27.0.0 beta 2 #38137

Closed

27.0.0 beta 2 #38139

Merged

skjnldsv removed this from the Nextcloud 27 milestone May 9, 2023

kesselb mentioned this pull request May 30, 2023

feature-policy header should be replaced with permissions-policy #38515

Closed

kesselb force-pushed the enh/permission_policy branch from f65ce54 to 8d9769a Compare May 30, 2023 19:42

kesselb added 2 commits May 30, 2023 21:44

fixup! FeaturePolicy => PermissionPolicy

118cfd6

Signed-off-by: Daniel Kesselberg <[email protected]>

fixup! FeaturePolicy => PermissionPolicy

ce8e7d1

Signed-off-by: Daniel Kesselberg <[email protected]>

solracsf added this to the Nextcloud 28 milestone May 31, 2023

solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 31, 2023

MichaIng reviewed Jun 5, 2023

View reviewed changes

LukasReschke removed their request for review June 5, 2023 10:10

skjnldsv mentioned this pull request Nov 1, 2023

chore: 28.0.0 beta 1 #41228

Merged

This was referenced Nov 6, 2023

28.0.0 beta 2 #41314

Merged

28.0.0 beta 3 #41379

Merged

This was referenced Nov 14, 2023

28.0.0 beta 4 #41477

Merged

28.0.0 RC1 #41621

Merged

blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023

skjnldsv removed this from the Nextcloud 29 milestone Feb 27, 2024

skjnldsv closed this Feb 27, 2024

skjnldsv removed the 3. to review Waiting for reviews label Feb 27, 2024

skjnldsv deleted the enh/permission_policy branch February 27, 2024 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FeaturePolicy => PermissionPolicy #23825

FeaturePolicy => PermissionPolicy #23825

rullzer commented Nov 1, 2020 •

edited by joshtrichards

Loading

faily-bot bot commented Nov 19, 2020

MorrisJobke commented May 20, 2021

kesselb commented May 30, 2023

solracsf commented Jun 4, 2023

MichaIng Jun 5, 2023 •

edited

Loading

MichaIng Jun 5, 2023

MichaIng Jun 5, 2023

skjnldsv commented Feb 27, 2024

	* @depreacted 21.0.0 use \OCP\AppFramework\Http\PermissionPolicy
	* @deprecated 28.0.0 use \OCP\AppFramework\Http\PermissionPolicy

FeaturePolicy => PermissionPolicy #23825

FeaturePolicy => PermissionPolicy #23825

Conversation

rullzer commented Nov 1, 2020 • edited by joshtrichards Loading

faily-bot bot commented Nov 19, 2020

Status of 35702: failure

checkers

nodb

MorrisJobke commented May 20, 2021

kesselb commented May 30, 2023

solracsf commented Jun 4, 2023

MichaIng Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

MichaIng Jun 5, 2023

Choose a reason for hiding this comment

MichaIng Jun 5, 2023

Choose a reason for hiding this comment

skjnldsv commented Feb 27, 2024

rullzer commented Nov 1, 2020 •

edited by joshtrichards

Loading

MichaIng Jun 5, 2023 •

edited

Loading