improve handling of files we can't access in the scanner #22943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable20 |
|
/backport to stable19 |
juliusknorr
approved these changes
Sep 22, 2020
juliusknorr
added
4. to release
|
static code analysis is not happy: https://github.com/nextcloud/server/pull/22943/checks?check_run_id=1134675980 |
MorrisJobke
added
2. developing
|
@icewind1991 rebase and fix psalm ? |
icewind1991
force-pushed
the
scanner-no-access-handling
branch
from
6039742 to
7565b10
Compare
|
rebasing made psalm happy |
icewind1991
added
4. to release
|
@icewind1991 could you check the tests? |
|
CI unhappy, 35 errors in samba tests |
Merged
This comment has been minimized.
This comment has been minimized.
nextcloud-command
force-pushed
the
scanner-no-access-handling
branch
from
7565b10 to
986a242
Compare
|
Samba tests failing |
|
/rebase |
nextcloud-command
force-pushed
the
scanner-no-access-handling
branch
from
986a242 to
ebab4f8
Compare
icewind1991
force-pushed
the
scanner-no-access-handling
branch
from
ebab4f8 to
2364d1c
Compare
instead of erroring, remove the items from the cache. this situation can be triggered if a user has access to a file but looses it afterwards Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
scanner-no-access-handling
branch
from
2364d1c to
b1f352c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of erroring, remove the items from the cache.
this situation can be triggered if a user has access to a file but looses it afterwards
Signed-off-by: Robin Appelman [email protected]