Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help static code analysis to understand code #22890

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Help static code analysis to understand code #22890

merged 2 commits into from
Sep 17, 2020

Conversation

MorrisJobke
Copy link
Member

It adds proper type hints to private namespace to allow private namespace methods.

Extracted from #18680 by @kesselb

@kesselb @MorrisJobke
Help static code analysis to understand code.
096fe20 
It adds proper type hints to private namespace to allow private namespace methods.

Signed-off-by: Daniel Kesselberg <[email protected]>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Sep 16, 2020
@MorrisJobke MorrisJobke added this to the Nextcloud 20 milestone Sep 16, 2020
@MorrisJobke
Update baseline
c6948c2 
Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke mentioned this pull request Sep 16, 2020
Closed
@faily-bot
Copy link

faily-bot bot commented Sep 16, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33113: failure

samba

Show full log 
There was 1 failure:

1) OCA\Files_External\Tests\Storage\SmbTest::testNotifyListen
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
 OC\Files\Notify\Change Object (
-    'type' => 1
+    'type' => 3

/drone/src/apps/files_external/tests/Storage/SmbTest.php:145

@MorrisJobke MorrisJobke mentioned this pull request Sep 16, 2020
Merged
5 tasks
@rullzer rullzer merged commit 05edd1e into master Sep 17, 2020
@rullzer rullzer deleted the techdebt/18680/help-static-code-analysis-understand-code branch September 17, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

@gary-kim gary-kim Awaiting requested review from gary-kim

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @rullzer @skjnldsv @kesselb