Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate sentence in 'Reasons to use Nextcloud.pdf' #22859

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

jancborchardt
Copy link
Member

Thanks @jakobroehrl for the note and Marija for the fix!

On Page 10 this sentence was doubled: "Create any number of private or shared Kanban-style task boards"

Please review @jospoortvliet @rullzer @karlitschek

Also, is it possible that we put this file next to the "welcome.txt" of the example files in the empty dev instance as well? This will also spread the file further to people who are already more excited about Nextcloud so they can use it to spread it, which is kind of the idea?

@karlitschek
Copy link
Member

Looks good.
Sure, we can also put it into the example_files files. Good idea!

@faily-bot
Copy link

faily-bot bot commented Sep 15, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33073: failure

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #66 ('folder', 7, 13)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

@rullzer
Copy link
Member

rullzer commented Sep 15, 2020

Also, is it possible that we put this file next to the "welcome.txt" of the example files in the empty dev instance as well? This will also spread the file further to people who are already more excited about Nextcloud so they can use it to spread it, which is kind of the idea?

my bet is that makes a lot of tests do boom. So that would need fixing.
But this will be part of the skeleton files. So people that use the demo will see it. I really doubt a lot of people that never tried nextcloud directly start with deploying from git. ;)

@jancborchardt
Copy link
Member Author

I really doubt a lot of people that never tried nextcloud directly start with deploying from git. ;)

The idea was more that if you are as excited about Nextcloud already that you set up a local development environment, having this "Reasons to use Nextcloud.pdf" file directly in the dev instance as well might give you the nudge to share that further. Possibly that person is a sysadmin or technical contact in some company and can share it with decision makers.

@rullzer
Copy link
Member

rullzer commented Sep 15, 2020

So my guess was right. It does make a lot of tests do boom.

I vote to just get this in. People that are excited don't just setup a dev environment. They also have a full setup running. So they will see the file.

@rullzer rullzer merged commit 2209d0a into master Sep 15, 2020
@rullzer rullzer deleted the fix/reasons-to-use-pdf branch September 15, 2020 13:21
@MorrisJobke MorrisJobke mentioned this pull request Sep 16, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants