-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if quota should be applied to path when creating directories #22657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the files_trashbin hierarchy of a user could not been created as the mkdir operations were blocked by the quota storage wrapper. Even with 0 quota, users should be able to have a trashbin for external storages. Signed-off-by: Julius Härtl <[email protected]>
|
rullzer
approved these changes
Sep 8, 2020
Signed-off-by: Julius Härtl <[email protected]>
blizzz
approved these changes
Sep 8, 2020
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32854: failureintegration-sharing-v1-video-verification
Show full log
|
Signed-off-by: Morris Jobke <[email protected]>
I fixed the code style (was a single additional empty line in a test). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the files_trashbin hierarchy of a user could not been created as the mkdir operations were blocked by the quota storage wrapper. Even with 0 quota, users should be able to have a trashbin for external storages.
Steps to reproduce:
Before:
💥 The file gets deleted but with a parent id of -1 in the filecache
After:
✔️ The files_trashbin/files/ hierarchy gets added to the filecache and the file is properly visible in the trashbin