Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change status popover container #22615

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

raimund-schluessler
Copy link
Member

This PR prevents the status popover from fluttering when scrolling. Requires nextcloud-libraries/nextcloud-vue#1389 and #22614.

@georgehrke
Copy link
Member

Can we actually use header here? I remember that PR from @ma12-co that you have to pass an Element object to the popover component.

@raimund-schluessler
Copy link
Member Author

Can we actually use header here? I remember that PR from @ma12-co that you have to pass an Element object to the popover component.

For the container a selector is necessary, see https://github.com/nextcloud/nextcloud-vue/pull/1389/files#diff-2bfd37a0e52db490178eb64c7675ecc9R277 and the fundamental implementation in v-tooltip: https://github.com/Akryum/v-tooltip#other-options

A DOM Element must be used for the boundariesElement though (that's why you probably remember this).

@raimund-schluessler
Copy link
Member Author

/compile amend /

Signed-off-by: Raimund Schlüßler <[email protected]>
@faily-bot
Copy link

faily-bot bot commented Sep 8, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32779: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #128 ('folder', 23, 25)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

mariadb10.4-php7.3

Could not fetch logs

@raimund-schluessler
Copy link
Member Author

Rebased.

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 10, 2020
@MorrisJobke MorrisJobke merged commit bd5a297 into master Sep 10, 2020
@MorrisJobke MorrisJobke deleted the fix/22606/popover-flutter branch September 10, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants