Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing alias for OCP\Settings\IManager and deprecate the old one #22597

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling [email protected]

@faily-bot
Copy link

faily-bot bot commented Sep 4, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32660: failure

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #0 (OC\Files\Search\SearchComparison Object (...), array(1))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
+    0 => '424'
 )

/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

@rullzer rullzer merged commit c538b1e into master Sep 4, 2020
@rullzer rullzer deleted the techdebt/noid/allow-to-di-the-settings-manager branch September 4, 2020 18:22
@rullzer rullzer mentioned this pull request Sep 6, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants