Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved status cleanup #22548

Merged
merged 6 commits into from
Sep 7, 2020
Merged

Improved status cleanup #22548

merged 6 commits into from
Sep 7, 2020

Conversation

georgehrke
Copy link
Member

No description provided.

@georgehrke georgehrke added the 2. developing Work in progress label Sep 2, 2020
@georgehrke georgehrke added this to the Nextcloud 20 milestone Sep 2, 2020
This was referenced Sep 3, 2020
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 3, 2020
@georgehrke georgehrke marked this pull request as ready for review September 3, 2020 14:25
@georgehrke georgehrke force-pushed the bugfix/noid/improved_status_cleanup branch from 00aee2f to 73bbbad Compare September 3, 2020 16:59
@georgehrke
Copy link
Member Author

Squashed fixup commits

@georgehrke georgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 3, 2020
@georgehrke
Copy link
Member Author

There is one PR related unit test failure. Will look into it tomorrow

@georgehrke georgehrke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Sep 3, 2020
@georgehrke georgehrke force-pushed the bugfix/noid/improved_status_cleanup branch from 73bbbad to 0bbf45c Compare September 7, 2020 07:41
@georgehrke georgehrke force-pushed the bugfix/noid/improved_status_cleanup branch from 0bbf45c to d7ccc61 Compare September 7, 2020 09:30
@georgehrke
Copy link
Member Author

Squashed commits

@georgehrke georgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 7, 2020
@faily-bot
Copy link

faily-bot bot commented Sep 7, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32743: failure

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopyFromSameStorage with data set #0 ('/source.txt', '/target.txt')
Expected /target.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
-Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
-Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
-Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'
+''

/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:600

@rullzer rullzer merged commit 99ee00b into master Sep 7, 2020
@rullzer rullzer deleted the bugfix/noid/improved_status_cleanup branch September 7, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants