-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix userid casting in notifications #15912
Conversation
/backport to stable16 |
@ChristophWurst this is what we should do right? Because tests are failing |
1afcef5
to
490d1f0
Compare
Not for primitive types. Only for built-in functions like |
Yep, I just realised that ^^ |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
490d1f0
to
49d5030
Compare
backport to stable16 in #15925 |
cc @corecode |
thanks! |
@skjnldsv Tests are still failing due to this on master. Mind to have a look?
|
Ah damn, I missed those! |
the type hint is also part of #15040 Also I would suggest to revert the backport of the type hint and only keep the cast in 16, which also already fixes the problem. |
@nickvergessen sure thing! |
Fix #15677