Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MissingMandatoryParametersException for share notifications #1394

Merged
merged 1 commit into from
Sep 13, 2016

Conversation

nickvergessen
Copy link
Member

The routing system is non-forgiving.

@rullzer @schiessle

Steps

  1. Enable share notifications
  2. Set up a second user with email
  3. Share a file with the user
  4. Send notification

Expected

Email is sent, return is 200

Actual

Symfony\Component\Routing\Exception\MissingMandatoryParametersException
Some mandatory parameters are missing ("fileid") to generate a URL for route "files.viewcontroller.showFile"

No email

Fix #1277

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @LukasReschke and @schiessle to be potential reviewers

@MorrisJobke
Copy link
Member

Tested and works 👍

@rullzer
Copy link
Member

rullzer commented Sep 13, 2016

LGTM

@rullzer rullzer merged commit 43bff15 into stable10 Sep 13, 2016
@rullzer rullzer deleted the fix-share-notification-10 branch September 13, 2016 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants