Fix PHPUnit warnings on NODB runs #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @ChristophWurst and @DeepDiver1975 to be potential reviewers |
| @@ -195,7 +195,7 @@ public function testValidateUsedCode() { | |||
| ->with($user) | |||
| ->will($this->returnValue($codes)); | |||
| $this->hasher->expects($this->never()) | |||
| ->method('verifiy'); | |||
| ->method('verify'); | |||
There was a problem hiding this comment.
shouldn't this test have failed because of "unmockable method"?
rullzer
force-pushed
the
nodb_getmock_be_gone
branch
from
5e675b7 to
680b557
Compare
| @@ -49,7 +49,7 @@ protected function setUp(){ | |||
| ->disableOriginalConstructor() | |||
| ->getMock(); | |||
|
|
|||
| $this->query = $this->getMock('\PDOStatement'); | |||
| $this->query = $this->createMock('\PDOStatement'); | |||
There was a problem hiding this comment.
why didn't you use the ::class property here?
There was a problem hiding this comment.
ah yeah I could now probabaly Just forgot.
|
👍 looks good |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of getMock fixes.
Cleans up the unit test output significantly and makes spotting new warnings a lot easier!
CC: @MorrisJobke @nickvergessen @LukasReschke @icewind1991