Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Swift Mailer streaming options in config, fixes #12702 #12766

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Expose Swift Mailer streaming options in config, fixes #12702 #12766

merged 3 commits into from
Dec 18, 2018

Conversation

stalker314314
Copy link
Contributor

@stalker314314 stalker314314 commented Nov 30, 2018 •
edited by ChristophWurst
Loading

Backward compatible addition to expose streaming options, so user can define them in their repsective configs.

Swift Mailer added streaming options 3 years ago in this commit. Seems Nextcloud is having proper version.

Fixes #12702

@stalker314314
Copy link
Contributor Author

Friendly ping:)

@ChristophWurst
Copy link
Member

Hey @stalker314314,

thanks for your contribution ✌️

I'm sorry this got no attention yet, we release Nextcloud 15 today and we were busy preparing that.

Let me assign the corresponding labels so this gets reviewed and merged soonish :)

@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Dec 10, 2018
@stalker314314
Copy link
Contributor Author

Ping. Pending for quite some time now! Can someone please take a look?

@nickvergessen
Copy link
Member

The only problem I have with this is that your config is then specific to Swift Mailer.
But well, if we ever replace it we will find a way.

@stalker314314
Addressing comments, count to empty
8101059 
Signed-off-by: Branko Kokanovic <[email protected]>
@stalker314314
Addressing comments, array() to []
7cef9b0 
Signed-off-by: Branko Kokanovic <[email protected]>
skjnldsv
skjnldsv approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

@skjnldsv
Copy link
Member

Failure unrelated.

@skjnldsv skjnldsv merged commit 6f994be into nextcloud:master Dec 18, 2018
@welcome
Copy link

welcome bot commented Dec 18, 2018

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@skjnldsv
Copy link
Member

@stalker314314 Could you add your config to the documentation please? :)

@skjnldsv skjnldsv added the pending documentation This pull request needs an associated documentation update label Dec 18, 2018
@stalker314314 stalker314314 mentioned this pull request Dec 18, 2018
Merged
@skjnldsv skjnldsv removed the pending documentation This pull request needs an associated documentation update label Dec 18, 2018
@kesselb kesselb mentioned this pull request Jul 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: emails
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
4 participants
@stalker314314 @ChristophWurst @nickvergessen @skjnldsv