-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UniqueConstraintViolationException while insert into oc_filecache #12411
Fix UniqueConstraintViolationException while insert into oc_filecache #12411
Conversation
* fixes #6160 by not being prone to the race condition in insertIfNotExists * fixes #12228 by not using a query that can result in a deadlock * replaces the insertIfNotExists call with an insert which is wrapped into a try-catch block Signed-off-by: Morris Jobke <[email protected]>
89ba561
to
93c62d7
Compare
$builder->insert('filecache'); | ||
|
||
foreach ($values as $column => $value) { | ||
$builder->setValue($column, $builder->createNamedParameter($value)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also said, that there is an sql injection problem (this came from our plugin to Phan). I double checked and the column as well as the argument are both properly escaped.
Query looks good and unique constraint is working. |
Yep - I didn't changed anything there. We can tackle the types later, but for now I want to go for the least intrusive way. |
I would back port this one to stable13 and stable14 as well because it is a smaller and not that invasive version of #12371 and it also fixes the deadlocks.