Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the app menu #10787

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Fixes the app menu #10787

merged 2 commits into from
Aug 22, 2018

Conversation

weeman1337
Copy link
Member

@weeman1337 weeman1337 commented Aug 21, 2018

Adds and updates some z-index to make it possible to click the last app.

closes #10786

Signed-off-by: Michael Weimann <[email protected]>
@weeman1337 weeman1337 added bug 3. to review Waiting for reviews labels Aug 21, 2018
@weeman1337 weeman1337 added this to the Nextcloud 14 milestone Aug 21, 2018
@skjnldsv
Copy link
Member

Thanks I was preparing something as well! :)

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and works 👍

core/js/js.js Outdated
// prevent the link event (append anchor to URL)
event.preventDefault();

console.log(event);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug output? 🙈

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/10786/click-the-last-app branch from 9204b91 to ba66cad Compare August 22, 2018 07:54
@skjnldsv skjnldsv merged commit 04a7447 into master Aug 22, 2018
@skjnldsv skjnldsv deleted the fix/10786/click-the-last-app branch August 22, 2018 14:11
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 22, 2018
@rullzer rullzer mentioned this pull request Aug 24, 2018
3 tasks
@MorrisJobke MorrisJobke mentioned this pull request Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't click the last app
4 participants