Adds a permission check for app directories #10628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Weimann <[email protected]>
Signed-off-by: Michael Weimann <[email protected]>
Signed-off-by: Michael Weimann <[email protected]>
Signed-off-by: Michael Weimann <[email protected]>
weeman1337
requested review from
rullzer,
nickvergessen,
MorrisJobke,
ChristophWurst and
juliusknorr
skjnldsv
approved these changes
Aug 20, 2018
|
Looks great!! |
Merged
|
a setup where nextcloud's program files (as opposed to state/data files - NEXTCLOUD_CONFIG_DIR and "datadirectory" in config.php) are read-only to the runtime can also be intentional. I for one don't trust .php programs overwriting themselves. i't's also common on stateless infrastructure. is there a way to dismiss this warning? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a setup check for the permissions of the app root directories.
There is a test for the case the permissions are fine. It's hard to add a test for the wrong permissions, because an ordinary user can't do a chown.
Replaces #10538
Closes #10154