theme changes (logo, background) only applied to first trusted domain

[rtheys]

Steps to reproduce

1. Configure multiple domains in the trusted_domains parameter
2. Configure theming options (custom color, background,...) when logged in on the first domain
3. Go to the instance using another domain from the trusted_domains list

Expected behaviour

The same theming options are used

Actual behaviour

Only the tag line is shown on both domains. Other theme settings (background, color, logo) are the defaults instead of the configured ones.

Server configuration

Operating system:
CentOS 7.4

Web server:
Apache 2.4

Database:
MySQL

PHP version:
7.0

Nextcloud version: (see Nextcloud admin page)
12.0.3

Updated from an older Nextcloud/ownCloud or fresh install:
Upgraded from owncloud 9 -> nextcloud 9 -> 10 -> 11 -> 12

Where did you install Nextcloud from:
download from website

Signing status:

Signing status

No errors have been found.

List of activated apps:

App list

Enabled: - activity: 2.5.2 - admin_audit: 1.2.0 - bruteforcesettings: 1.0.2 - calendar: 1.5.6 - comments: 1.2.0 - contacts: 2.0.1 - dav: 1.3.0 - federatedfilesharing: 1.2.0 - files: 1.7.2 - files_sharing: 1.4.0 - files_texteditor: 2.4.1 - files_trashbin: 1.2.0 - files_versions: 1.5.0 - files_videoplayer: 1.1.0 - firstrunwizard: 2.1 - gallery: 17.0.0 - logreader: 2.0.0 - lookup_server_connector: 1.0.0 - nextcloud_announcements: 1.1 - notifications: 2.0.0 - oauth2: 1.0.5 - password_policy: 1.2.2 - provisioning_api: 1.2.0 - serverinfo: 1.2.0 - sharebymail: 1.2.0 - survey_client: 1.0.0 - systemtags: 1.2.0 - theming: 1.3.0 - twofactor_backupcodes: 1.1.1 - updatenotification: 1.2.0 - user_ldap: 1.2.1 - workflowengine: 1.2.0 Disabled: - encryption - federation - files_external - files_pdfviewer - user_external

Nextcloud configuration:

Config report

"system": {
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "dbtype": "mysql",
    "version": "12.0.3.3",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbtableprefix": "oc_",
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "forcessl": true,
    "log_authfailip": true,
    "loglevel": 1,
    "logtimezone": "Europe\/Brussels",
    "ldapIgnoreNamingRules": false,
    "enable_avatars": false,
    "updatechecker": false,
    "overwritehost": "",
    "enable_previews": false,
    "theme": "",
    "maintenance": false,
    "trusted_domains": [
        "cloud.esat.kuleuven.be",
        "owncloud.esat.kuleuven.be"
    ],
    "secret": "***REMOVED SENSITIVE VALUE***",
    "share_folder": "\/Shared",
    "mail_from_address": "owncloud",
    "mail_smtpmode": "php",
    "mail_domain": "esat.kuleuven.be",
    "memcache.local": "\\OC\\Memcache\\Redis",
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "redis": {
        "host": "\/var\/run\/redis\/redis.sock",
        "port": 0,
        "timeout": 0
    },
    "trashbin_retention_obligation": "auto",
    "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
    "log_rotate_size": 1073741824,
    "overwrite.cli.url": "https:\/\/cloud.esat.kuleuven.be"
}

}

Are you using external storage, if yes which one: local/smb/sftp/...
No

Are you using encryption: yes/no
No

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
LDAP

LDAP configuration (delete this part if not used)

LDAP config

Not relevant

Client configuration

Browser:
Firefox

Operating system:
Fedora 27, CentOS 7, ...

Logs

Web server error log

Web server error log

Nothing in web server error log

Nextcloud log (data/nextcloud.log)

Nextcloud log

Nothing relevant in log.

Browser log

Browser log

Network tab of firefox shows for the domain that works:

https://cloud.esat.kuleuven.be/index.php/apps/theming/loginbackground?v=6
https://cloud.esat.kuleuven.be/index.php/apps/theming/logo?v=6

For the domain that does not work:

https://owncloud.esat.kuleuven.be/core/img/background.jpg?v=0
https://owncloud.esat.kuleuven.be/index.php/apps/theming/js/theming?v=6

[blizzz]

@nextcloud/theming

[pieter-groeneweg]

Wouldn't it be nice to be able to set a theme per trusted domain?

[juliusknorr]

Wouldn't it be nice to be able to set a theme per trusted domain?

We discussed that in the past, I cannot find the issue right now, but that would be a lot of additional code paths that all need to be tested. Also it will make theming much more complicated, so I don't see this happen. 😉

@rtheys Can you still reproduce the issue on 12.0.5?

[rtheys]

Hi, I've tested it with 12.0.5 and it seems to be fixed now. Regards, Rik

…

On Fri, Feb 2, 2018 at 12:11 PM, Julius Härtl ***@***.***> wrote: Wouldn't it be nice to be able to set a theme per trusted domain? We discussed that in the past, I cannot find the issue right now, but that would be a lot of additional code paths that all need to be tested. Also it will make theming much more complicated, so I don't see this happen. 😉 @rtheys <https://github.com/rtheys> Can you still reproduce the issue on 12.0.5? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7383 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEQ2l5BwvMeEr05cGZIlJNcKUaF05gT8ks5tQu16gaJpZM4Q0W1P> .

-- Rik

[skjnldsv]

Awesome! :)

[gcommit]

I have the same issue on 13.0.1
As a workaround you can install the app "Unsplash" and deactivate it. For some reason this triggers a update of the login screen (do it that way, if you don't want to do changes on system itself)