Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize style of 'Alternative Logins' buttons #6367

Closed
leonklingele-work opened this issue Sep 5, 2017 · 1 comment · Fixed by #6370
Closed

Modernize style of 'Alternative Logins' buttons #6367

leonklingele-work opened this issue Sep 5, 2017 · 1 comment · Fixed by #6370
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 13

Comments

@leonklingele-work
Copy link

Apps can add their own 'Login' mechanism by using \OC_App::registerLogIn which displays a new button on the initial login page (see the following screenshot):

nextcloud-alternative-login

These buttons have probably not been redesigned for years 🙀

How to reproduce

Install and enable the Registration app.
@MorrisJobke MorrisJobke added design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. labels Sep 5, 2017
MorrisJobke added a commit that referenced this issue Sep 5, 2017
@MorrisJobke
Fix layout of alternative login buttons
bfaea8b 
* fixes #6367

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke mentioned this issue Sep 5, 2017
Merged
@MorrisJobke
Copy link
Member

Fix is in #6370

@MorrisJobke MorrisJobke removed their assignment Sep 5, 2017
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Sep 5, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Sep 5, 2017
MorrisJobke added a commit that referenced this issue Sep 6, 2017
@MorrisJobke
Fix layout of alternative login buttons
f5aea79 
* fixes #6367

Signed-off-by: Morris Jobke <[email protected]>
@nextcloud-bot nextcloud-bot mentioned this issue Aug 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging a pull request may close this issue.

Fix layout of alternative login buttons nextcloud/server
3 participants
@MorrisJobke @jancborchardt @leonklingele-work