Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & Improve Design of Nextcloud Mail Templates #48095

Open
sorbaugh opened this issue Sep 16, 2024 · 3 comments
Open

Update & Improve Design of Nextcloud Mail Templates #48095

sorbaugh opened this issue Sep 16, 2024 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: emails

Comments

@sorbaugh
Copy link
Contributor

sorbaugh commented Sep 16, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Currently there has been nice design updates on Nextcloud as a whole, but it seems that the mail templates have been straggling a lot. There are some style aspects that could be improved, such as the spacing and font, and maybe there are other creative aspects that could be included which I'd leave to Nextcloud's awesome design team.

Technical aspects:

  • The code/approach for the mail template structure has grown quite outdated, hard to read and maintain. See here.
  • We should use a currently maintained mail-templating library to support as many mail-clients as possible. Just one example: https://documentation.mjml.io/

One example (Password-forgotten email):

  • I feel like the logo takes a bit too much space.
  • The font on the link is different than the one used otherwise in Nextcloud (although admittedly I'm uncertain if we can have Nextcloud Font supported accross multiple mail clients).
  • The Footer text is hard to read on white background.

Bildschirmfoto 2024-09-16 um 16 25 54

Anyway, maybe something that could be improved overall to make the NC mail templates feel nice and professional :) What do you think!

@sorbaugh sorbaugh added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 16, 2024
@marcoambrosini marcoambrosini moved this to 🧭 Planning evaluation / ideas in 🖍 Design team Sep 16, 2024
@marcoambrosini marcoambrosini added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 16, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Sep 16, 2024

We could list all the various emails we have, so it's easier to know what the design team is working with :)

EDIT: or even better, the way our template work.
So you know what our backend supports and what we're epected to be able to adjust
Goal is to do a design change, not a backend API change ⚠️

The API is here, it's easy to understand what we support:
https://github.com/nextcloud/server/blob/af6de04e9e141466dc229e444ff3f146f4a34765/lib/public/Mail/IEMailTemplate.php

@skjnldsv
Copy link
Member

Example pictures: image and image

We support:

addHeading

image

addBodyText

image

addBodyListItem

image

addBodyButtonGroup

image

addBodyButton

image

image

@skjnldsv
Copy link
Member

Related bug: #37966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: emails
Projects
Status: 🧭 Planning evaluation / ideas
Development

No branches or pull requests

4 participants