Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only Logo from Theming in emails without background color #31320

Closed
reos-rcrozier opened this issue Feb 22, 2022 · 8 comments
Closed

Use only Logo from Theming in emails without background color #31320

reos-rcrozier opened this issue Feb 22, 2022 · 8 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: emails

Comments

@reos-rcrozier
Copy link

Is your feature request related to a problem? Please describe.

Currently if you modify the theming in Nextcloud Settings->Theming calendar emails are modified also, however, the modification is very crude. For example in my theming I have a dark green background color, and the themed emal has a dark green blob at the top overlaid with black text containing the contents of the 'Name' field from the Theming setting. This is hard to read and looks very unprofessional.

Describe the solution you'd like

If the user has provided a logo in the theming section, display this logo at the top of calendar emails instead of the colored blob with overlaid text. If you don't have a logo at least choose a suitable text color like white if a dark background color has been selected.

Describe alternatives you've considered

No response

Additional context

No response

@ChristophWurst
Copy link
Member

could you add screenshots?

@reos-rcrozier
Copy link
Author

Actually, when I went to screenshot this, I realised I had made a mistake, the logo is actually displayed, it's overlaid on the colored blob (I hadn't allowed remote content to be displayed for the message). However, I would still prefer just the logo, and no background color, and the text displayed before the logo image is loaded to be either an appropriate color, or just plain black, no background color. Here's how it looks in our case after loading:

image

Before allowing the images to load:

image

@no-response no-response bot removed the needs info label Feb 22, 2022
@reos-rcrozier reos-rcrozier changed the title Use Logo from Theming in Calendar emails Use only Logo from Theming in Calendar emails without background color Feb 22, 2022
@tcitworld tcitworld transferred this issue from nextcloud/calendar Feb 22, 2022
@tcitworld tcitworld changed the title Use only Logo from Theming in Calendar emails without background color Use only Logo from Theming in emails without background color Feb 22, 2022
@tcitworld
Copy link
Member

Renamed and moved to server as there's nothing specific about calendar emails

@solracsf
Copy link
Member

What about if you use a full-white logo in your Nextcloud? Without a background, logo won't display.

@reos-rcrozier
Copy link
Author

@acsfer, I'm not sure exactly what you mean by a full-white logo? Or exactly what you mean by "Without a background, logo won't display".

I have tried a white logo foreground with transparent background (but the logo shown above has transparent background anyway). This doesn't make a difference to the issue that before logos are loaded the replacement text in the email is black, which doesn't look so good on a dark background.

Basically it would be nice to expose some aspects of email themes in the the Theming interface. For example the ability to change the header background color separately from the Nextcloud theme color, and the ability to change the alternate text color for the logo, and perhaps even choose a different logo file for the emails.

@solracsf
Copy link
Member

solracsf commented Feb 23, 2022

Use this logo. https://logoseducation.group/wp-content/uploads/2020/10/White-logo-no-background.png

And imagine it on the mail body without a color background (white logo + white background = no logo display at all).

Basically it would be nice to expose some aspects of email themes in the the Theming interface. For example the ability to change the header background color separately from the Nextcloud theme color, and the ability to change the alternate text color for the logo, and perhaps even choose a different logo file for the emails.

This can be done by overriding the emails class (not by the WebUI at this time).

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 1 - to develop labels Feb 28, 2022
@papahausa
Copy link

hello. i have the same. where in mail templates i can remove this backgroung?
Screenshot_5

@skjnldsv
Copy link
Member

Hi,

I'll close this ticket. We don't allow customizing emails templates to that extreme. Otherwise we'll never stop oroviding configs switches or customization options :(
There is some discussion regarding a new email design here: #48095
Thank you :)

@skjnldsv skjnldsv closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: emails
Projects
None yet
Development

No branches or pull requests

6 participants