Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [f2v] Spaces are double encoded in directory and filenames #40755

Closed
5 of 8 tasks
max-nextcloud opened this issue Oct 3, 2023 · 2 comments · Fixed by #40756
Closed
5 of 8 tasks

[Bug]: [f2v] Spaces are double encoded in directory and filenames #40755

max-nextcloud opened this issue Oct 3, 2023 · 2 comments · Fixed by #40756

Comments

@max-nextcloud
Copy link
Contributor

⚠️ This issue respects the following points: ⚠️

Bug description

Filenames and foldernames with spaces are shown with %20 instead:
Bildschirmfoto vom 2023-10-03 15-57-51

Folder creation seems to work fine but on a reload they are also shown with %20.

Steps to reproduce

  1. Run the current master branch
  2. Go to apps/files and create a folder and upload a file with spaces in the name
  3. Reload the page
  4. See the %20 like on the screenshot

Expected behavior

Properly handle spaces inside file and folder names - i.e. display them as a simple space.

Installation method

Other Community project

Nextcloud Server version

master

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

SQlite

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "debug": true,
        "profiler": true,
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/apps-extra",
                "url": "\/apps-extra",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/apps-writable",
                "url": "\/apps-writable",
                "writable": true
            }
        ],
        "allow_local_remote_servers": true,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "1025",
        "skeletondirectory": "\/skeleton",
        "loglevel": 2,
        "log_query": false,
        "query_log_file": "\/var\/www\/html\/data\/query.log",
        "diagnostics.logging": false,
        "diagnostics.logging.threshold": 0,
        "log.condition": {
            "apps": [
                "diagnostics",
                "admin_audit"
            ]
        },
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "nextcloud",
            "nextcloud.local",
            "192.168.23.6",
            "localhost"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "28.0.0.2",
        "overwrite.cli.url": "https:\/\/nextcloud.local",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "updater.release.channel": "git",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "overwriteprotocol": "https",
        "app_install_overwrite": [
            "collectives"
        ],
        "default_language": "en",
        "force_language": "en",
        "default_locale": "en_US",
        "force_locale": "en_US",
        "theme": "",
        "maintenance": false
    }
}

List of activated Apps

Enabled:
  - circles: 28.0.0-dev
  - cloud_federation_api: 1.11.0
  - collectives: 2.8.1
  - comments: 1.18.0
  - contacts: 5.4.0-rc.1
  - contactsinteraction: 1.9.0
  - dashboard: 7.8.0
  - dav: 1.28.0
  - federatedfilesharing: 1.18.0
  - federation: 1.18.0
  - files: 2.0.0
  - files_pdfviewer: 2.9.0
  - files_reminders: 1.0.0
  - files_sharing: 1.20.0
  - files_trashbin: 1.18.0
  - files_versions: 1.21.0
  - lookup_server_connector: 1.16.0
  - notifications: 2.16.0
  - oauth2: 1.16.2
  - provisioning_api: 1.18.0
  - recommendations: 2.0.0
  - settings: 1.10.0
  - sharebymail: 1.18.0
  - systemtags: 1.18.0
  - text: 3.9.0
  - theming: 2.3.0
  - twofactor_backupcodes: 1.17.0
  - updatenotification: 1.18.0
  - user_oidc: 1.3.3
  - user_status: 1.8.1
  - viewer: 2.2.0
  - weather_status: 1.8.0
  - workflowengine: 2.10.0
Disabled:
  - admin_audit: 1.18.0
  - data_request: 1.15.0
  - deck: 1.11.0-dev
  - encryption: 2.16.0
  - files_automatedtagging: 1.18.0
  - files_external: 1.20.0
  - files_lock: 27.0.0
  - files_retention: 1.16.0
  - files_zip: 1.4.0
  - hmr_enabler: 1.0.0
  - mail: 3.1.0-alpha.1
  - notestutorial: 20.0.0
  - password_policy: 1.18.0 (installed 1.18.0)
  - profiler: 1.2.0
  - richdocuments: 8.1.0-dev.1
  - tables: 0.4.0
  - testing: 1.18.0
  - user_ldap: 1.19.0

Nextcloud Signing status

git clone does not do integrity checks to my knowledge.

Nextcloud Logs

No response

Additional info

This is on a nextcloud-docker-dev instance.

@max-nextcloud max-nextcloud added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Oct 3, 2023
max-nextcloud added a commit to nextcloud/collectives that referenced this issue Oct 3, 2023
nextcloud/server#40755 is the files issue.

Work around it by using just a substring contained in the filename when testing master

Signed-off-by: Max <[email protected]>
max-nextcloud added a commit to nextcloud/collectives that referenced this issue Oct 3, 2023
nextcloud/server#40755 is the files issue.

Work around it by using just a substring contained in the filename when testing master

Signed-off-by: Max <[email protected]>
@ChristophWurst
Copy link
Member

👀 @kesselb

@kesselb
Copy link
Contributor

kesselb commented Oct 3, 2023

#40756

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Oct 3, 2023
@skjnldsv skjnldsv self-assigned this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants