Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

occ upgrade should be more verbose about versions #32648

Open
jficz opened this issue May 29, 2022 · 0 comments · May be fixed by #49956
Open

occ upgrade should be more verbose about versions #32648

jficz opened this issue May 29, 2022 · 0 comments · May be fixed by #49956
Assignees
@joshtrichards
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: install and update feature: occ papercut Annoying recurring issue with possibly simple fix.

Comments

@jficz
Copy link

jficz commented May 29, 2022

Is your feature request related to a problem? Please describe.

When running an upgrade I was stuck with Nextcloud or one of the apps require upgrade... even though I did
perform occ upgrade and even occ maintenance:repair repeatedly. I was unable to figure out what's wrong
because occ didn't give me any information on what apparently needs an upgrade and why.

There was nothing in any of the logs, occ didn't give out any more useful info with -vvv.

Turned out there was a leftover "old.config.php" file in the config dir with an older version set but I only realized
that after I disabled all possible apps and actually took a dive into the code to see how the "update needed"
is triggered.

Describe the solution you'd like

occ upgrade should be more specific about what needs upgrade and why (at least with -v*) , i.e. something like "[app] needs upgrade because installed version is X but the actual version on the filesystem is Y" or "Nextcloud needs upgrade because config says X but we have Y actually installed". If I had seen that the X version is different from what is on the filesystem my debugging path would have been different and probably much shorter.

Describe alternatives you've considered
No alternatives.
@jficz jficz added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels May 29, 2022
@joshtrichards joshtrichards mentioned this issue Sep 27, 2024
Open
@joshtrichards joshtrichards mentioned this issue Dec 21, 2024
Open
@joshtrichards joshtrichards added papercut Annoying recurring issue with possibly simple fix. feature: occ labels Dec 21, 2024
joshtrichards added a commit that referenced this issue Dec 21, 2024
@joshtrichards
fix: detect inadvertent overlapping config files that break upgrades
1f5d1d5 
Fixes #32648

Detects when there are multiple config files and any of them other than the default `config.php` contain a `version` string: the telltale sign of an inadvertent `*.config.php` (such as a backup) existing in `config/` and creating a conflict (which breaks upgrades).

Also refactors error message handling.

Signed-off-by: Josh <[email protected]>
@joshtrichards joshtrichards linked a pull request Dec 21, 2024 that will close this issue
Open
5 tasks
@joshtrichards joshtrichards self-assigned this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshtrichards joshtrichards

Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: install and update feature: occ papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: detect inadvertent overlapping config files that break things nextcloud/server
2 participants
@joshtrichards @jficz