Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the password does not work properly on macOS/Safari #27885

Closed
svdwal opened this issue Jul 9, 2021 · 1 comment · Fixed by #27949
Closed

Changing the password does not work properly on macOS/Safari #27885

svdwal opened this issue Jul 9, 2021 · 1 comment · Fixed by #27949
Labels
2. developing Work in progress enhancement

Comments

@svdwal
Copy link

svdwal commented Jul 9, 2021

In particular, Safari enters a new, strong password in the old password field. This makes it impossible to change to a new, automatically generated strong password that is immediately kept safe in the macOS keychain.

Generally, websites use three fields, the first one the old password and the next two the new passwords (which must be identical). I urge you to adopt that pattern as well, or instrument the password fields so Safari can work its password convenience magic properly.
CarlSchwan added a commit to CarlSchwan/server that referenced this issue Jul 13, 2021
@CarlSchwan
Add autocompletion for password reset
281a8fa 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Close nextcloud#27885

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan mentioned this issue Jul 13, 2021
Merged
@CarlSchwan
Copy link
Member

CarlSchwan commented Jul 13, 2021 •
edited
Loading

Hi svdwal,
I opened #27949. Since I don't have access to Safari, would you mind giving it a try if this works for you on Safari? Thanks :)

Edit: wrong link

CarlSchwan added a commit to CarlSchwan/server that referenced this issue Jul 13, 2021
@CarlSchwan
Add autocompletion for password reset
66e1f88 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close nextcloud#27885

Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan added a commit to CarlSchwan/server that referenced this issue Jul 13, 2021
@CarlSchwan
Add autocompletion for password reset
7344b2a 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close nextcloud#27885

Signed-off-by: Carl Schwan <[email protected]>
npmbuildbot-nextcloud bot pushed a commit to CarlSchwan/server that referenced this issue Jul 13, 2021
@CarlSchwan @npmbuildbot-nextcloud
Add autocompletion for password reset
1dd402b 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close nextcloud#27885

Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
CarlSchwan added a commit to CarlSchwan/server that referenced this issue Jul 14, 2021
@CarlSchwan @Pytal
Add autocompletion for password reset
bf2304a 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close nextcloud#27885

Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Co-authored-by: Pytal <[email protected]>
szaimen pushed a commit to CarlSchwan/server that referenced this issue Jul 14, 2021
@CarlSchwan @Pytal @szaimen
Add autocompletion for password reset
55e149d 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close nextcloud#27885

Signed-off-by: Carl Schwan <[email protected]>
Co-Authored-By: Julien Veyssier <[email protected]>
Co-Authored-By: Pytal <[email protected]>
npmbuildbot-nextcloud bot pushed a commit to CarlSchwan/server that referenced this issue Jul 14, 2021
@CarlSchwan @Pytal @npmbuildbot-nextcloud
Add autocompletion for password reset
ab1f4a6 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close nextcloud#27885

Signed-off-by: Carl Schwan <[email protected]>
Co-Authored-By: Julien Veyssier <[email protected]>
Co-Authored-By: Pytal <[email protected]>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
szaimen pushed a commit to CarlSchwan/server that referenced this issue Jul 14, 2021
@CarlSchwan @Pytal @szaimen
Add autocompletion for password reset
4e3b538 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close nextcloud#27885

Signed-off-by: Carl Schwan <[email protected]>
Co-Authored-By: Julien Veyssier <[email protected]>
Co-Authored-By: Pytal <[email protected]>
artonge pushed a commit that referenced this issue Jul 19, 2021
@CarlSchwan @Pytal @artonge
Add autocompletion for password reset
c40d75a 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close #27885

Signed-off-by: Carl Schwan <[email protected]>
Co-Authored-By: Julien Veyssier <[email protected]>
Co-Authored-By: Pytal <[email protected]>
CarlSchwan added a commit to CarlSchwan/server that referenced this issue Oct 22, 2021
@CarlSchwan @Pytal
Add autocompletion for password reset
b7a35af 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close nextcloud#27885

Signed-off-by: Carl Schwan <[email protected]>
Co-Authored-By: Julien Veyssier <[email protected]>
Co-Authored-By: Pytal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2. developing Work in progress enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add autocompletion for password reset CarlSchwan/server
3 participants
@svdwal @CarlSchwan @szaimen