Remake locale saving with Vue

Signed-off-by: Christopher Ng <[email protected]>
nextcloud · Sep 16, 2022 · f922b2f · f922b2f
1 parent b9c002d
commit f922b2f
Show file tree

Hide file tree

Showing 15 changed files with 332 additions and 131 deletions.
diff --git a/apps/settings/css/settings.css b/apps/settings/css/settings.css
diff --git a/apps/settings/css/settings.css.map b/apps/settings/css/settings.css.map
diff --git a/apps/settings/css/settings.scss b/apps/settings/css/settings.scss
@@ -47,14 +47,6 @@ input {
 	display: inline-grid;
 	grid-template-columns: 1fr;
 	grid-template-rows: 1fr 1fr 1fr 2fr;
-
-	#locale {
-		h3 {
-			height: 44px;
-			display: flex;
-			align-items: center;
-		}
-	}
 }
 
 .personal-show-container {
@@ -78,9 +70,7 @@ input {
 }
 
 select {
-	&#timezone,
-	&#languageinput,
-	&#localeinput {
+	&#timezone {
 		width: 100%;
 	}
 }

diff --git a/apps/settings/js/settings/personalInfo.js b/apps/settings/js/settings/personalInfo.js
@@ -108,62 +108,4 @@ window.addEventListener('DOMContentLoaded', function () {
 	});
 
 	federationSettingsView.render();
-
-	var updateLanguage = function () {
-		if (OC.PasswordConfirmation.requiresPasswordConfirmation()) {
-			OC.PasswordConfirmation.requirePasswordConfirmation(updateLanguage);
-			return;
-		}
-
-		var selectedLang = $("#languageinput").val(),
-			user = OC.getCurrentUser();
-
-		$.ajax({
-			url: OC.linkToOCS('cloud/users', 2) + user['uid'],
-			method: 'PUT',
-			data: {
-				key: 'language',
-				value: selectedLang
-			},
-			success: function() {
-				location.reload();
-			},
-			fail: function() {
-				OC.Notification.showTemporary(t('settings', 'An error occurred while changing your language. Please reload the page and try again.'));
-			}
-		});
-	};
-	$("#languageinput").change(updateLanguage);
-
-	var updateLocale = function () {
-		if (OC.PasswordConfirmation.requiresPasswordConfirmation()) {
-			OC.PasswordConfirmation.requirePasswordConfirmation(updateLocale);
-			return;
-		}
-
-		var selectedLocale = $("#localeinput").val(),
-			user = OC.getCurrentUser();
-
-		$.ajax({
-			url: OC.linkToOCS('cloud/users', 2) + user.uid,
-			method: 'PUT',
-			data: {
-				key: 'locale',
-				value: selectedLocale
-			},
-			success: function() {
-				moment.locale(selectedLocale);
-			},
-			fail: function() {
-				OC.Notification.showTemporary(t('settings', 'An error occurred while changing your locale. Please reload the page and try again.'));
-			}
-		});
-	};
-	$("#localeinput").change(updateLocale);
 });
-
-window.setInterval(function() {
-	$('#localeexample-time').text(moment().format('LTS'))
-	$('#localeexample-date').text(moment().format('L'))
-	$('#localeexample-fdow').text(t('settings', 'Week starts on {fdow}', { fdow: dayNames[firstDay] }))
-}, 1000)
diff --git a/apps/settings/lib/Settings/Personal/PersonalInfo.php b/apps/settings/lib/Settings/Personal/PersonalInfo.php
@@ -135,15 +135,14 @@ public function getForm(): TemplateResponse {
 			$totalSpace = \OC_Helper::humanFileSize($storageInfo['total']);
 		}
 
-		$localeParameters = $this->getLocales($user);
 		$messageParameters = $this->getMessageParameters($account);
 
 		$parameters = [
 			'federationEnabled' => $federationEnabled,
 			'lookupServerUploadEnabled' => $lookupServerUploadEnabled,
 			'isFairUseOfFreePushService' => $this->isFairUseOfFreePushService(),
 			'profileEnabledGlobally' => $this->profileManager->isProfileEnabled(),
-		] + $messageParameters + $localeParameters;
+		] + $messageParameters;
 
 		$personalInfoParameters = [
 			'userId' => $uid,
@@ -160,6 +159,7 @@ public function getForm(): TemplateResponse {
 			'website' => $this->getProperty($account, IAccountManager::PROPERTY_WEBSITE),
 			'twitter' => $this->getProperty($account, IAccountManager::PROPERTY_TWITTER),
 			'languageMap' => $this->getLanguageMap($user),
+			'localeMap' => $this->getLocaleMap($user),
 			'profileEnabledGlobally' => $this->profileManager->isProfileEnabled(),
 			'profileEnabled' => $this->profileManager->isProfileEnabled($user),
 			'organisation' => $this->getProperty($account, IAccountManager::PROPERTY_ORGANISATION),
@@ -315,31 +315,24 @@ private function getLanguageMap(IUser $user): array {
 		);
 	}
 
-	private function getLocales(IUser $user): array {
+	private function getLocaleMap(IUser $user): array {
 		$forceLanguage = $this->config->getSystemValue('force_locale', false);
 		if ($forceLanguage !== false) {
 			return [];
 		}
 
 		$uid = $user->getUID();
-
 		$userLocaleString = $this->config->getUserValue($uid, 'core', 'locale', $this->l10nFactory->findLocale());
-
 		$userLang = $this->config->getUserValue($uid, 'core', 'lang', $this->l10nFactory->findLanguage());
-
 		$localeCodes = $this->l10nFactory->findAvailableLocales();
-
-		$userLocale = array_filter($localeCodes, function ($value) use ($userLocaleString) {
-			return $userLocaleString === $value['code'];
-		});
+		$userLocale = array_filter($localeCodes, fn ($value) => $userLocaleString === $value['code']);
 
 		if (!empty($userLocale)) {
 			$userLocale = reset($userLocale);
 		}
 
-		$localesForLanguage = array_filter($localeCodes, function ($localeCode) use ($userLang) {
-			return 0 === strpos($localeCode['code'], $userLang);
-		});
+		$localesForLanguage = array_values(array_filter($localeCodes, fn ($localeCode) => strpos($localeCode['code'], $userLang) === 0));
+		$otherLocales = array_values(array_filter($localeCodes, fn ($localeCode) => strpos($localeCode['code'], $userLang) !== 0));
 
 		if (!$userLocale) {
 			$userLocale = [
@@ -349,10 +342,10 @@ private function getLocales(IUser $user): array {
 		}
 
 		return [
-			'activelocaleLang' => $userLocaleString,
-			'activelocale' => $userLocale,
-			'locales' => $localeCodes,
+			'activeLocaleLang' => $userLocaleString,
+			'activeLocale' => $userLocale,
 			'localesForLanguage' => $localesForLanguage,
+			'otherLocales' => $otherLocales,
 		];
 	}