Update Selenium driver for Mink from 1.3.1 to 1.4.0 in acceptance tests

Since version 1.4.0 the Selenium driver for Mink uses again the element on which the value was set (see minkphp/MinkSelenium2Driver#286). When creating a new folder or renaming one sending a new line ("\r") caused the element on which the value was set to be removed, so the element was no longer attached to the DOM when the driver tried to use it again, and thus a "StaleElementReference" exception was thrown. Due to this now it is needed to explicitly click the confirm button when creating a new folder. In the case of the renaming, on the other hand, nothing else besides not sending the new line is needed, as the Selenium driver now unfocuses the element (that is why it uses again the element after setting the value) which triggers the renaming. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nextcloud · Mar 6, 2021 · ea6e7e6 · ea6e7e6
1 parent 0bad065
commit ea6e7e6
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 18 deletions.
diff --git a/tests/acceptance/composer.json b/tests/acceptance/composer.json
@@ -3,7 +3,7 @@
     "behat/behat": "3.8.1",
     "behat/mink": "1.7.1",
     "behat/mink-extension": "2.3.1",
-    "behat/mink-selenium2-driver": "1.3.1",
+    "behat/mink-selenium2-driver": "1.4.0",
     "phpunit/phpunit": "6.5.14"
   },
   "autoload": {

diff --git a/tests/acceptance/composer.lock b/tests/acceptance/composer.lock
diff --git a/tests/acceptance/features/bootstrap/FileListContext.php b/tests/acceptance/features/bootstrap/FileListContext.php
@@ -126,11 +126,20 @@ public static function createNewFolderMenuItem($fileListAncestor) {
 	 * @return Locator
 	 */
 	public static function createNewFolderMenuItemNameInput($fileListAncestor) {
-		return Locator::forThe()->css(".filenameform input")->
+		return Locator::forThe()->css(".filenameform input[type=text]")->
 				descendantOf(self::createNewFolderMenuItem($fileListAncestor))->
 				describedAs("Name input in create new folder menu item in file list");
 	}
 
+	/**
+	 * @return Locator
+	 */
+	public static function createNewFolderMenuItemConfirmButton($fileListAncestor) {
+		return Locator::forThe()->css(".filenameform input[type=submit]")->
+				descendantOf(self::createNewFolderMenuItem($fileListAncestor))->
+				describedAs("Confirm button in create new folder menu item in file list");
+	}
+
 	/**
 	 * @return Locator
 	 */
@@ -356,7 +365,8 @@ public function iCreateANewFolderNamed($folderName) {
 		$this->actor->find(self::createMenuButton($this->fileListAncestor), 10)->click();
 
 		$this->actor->find(self::createNewFolderMenuItem($this->fileListAncestor), 2)->click();
-		$this->actor->find(self::createNewFolderMenuItemNameInput($this->fileListAncestor), 2)->setValue($folderName . "\r");
+		$this->actor->find(self::createNewFolderMenuItemNameInput($this->fileListAncestor), 2)->setValue($folderName);
+		$this->actor->find(self::createNewFolderMenuItemConfirmButton($this->fileListAncestor), 2)->click();
 	}
 
 	/**
@@ -410,7 +420,7 @@ public function iRenameTo($fileName1, $fileName2) {
 		// This should not be a problem, though, as the default behaviour is to
 		// bring the browser window to the foreground when switching to a
 		// different actor.
-		$this->actor->find(self::renameInputForFile($this->fileListAncestor, $fileName1), 10)->setValue($fileName2 . "\r");
+		$this->actor->find(self::renameInputForFile($this->fileListAncestor, $fileName1), 10)->setValue($fileName2);
 	}
 
 	/**