Help phan to understand code.

Signed-off-by: Daniel Kesselberg <[email protected]>
nextcloud · Sep 16, 2020 · afb2d8d · afb2d8d
1 parent ffaeda4
commit afb2d8d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/apps/provisioning_api/lib/AppInfo/Application.php b/apps/provisioning_api/lib/AppInfo/Application.php
@@ -64,8 +64,7 @@ public function __construct(array $urlParams = []) {
 			$isSubAdmin = false;
 
 			if ($user instanceof IUser) {
-				$groupManager = $server->getGroupManager();
-				assert($groupManager instanceof GroupManager);
+				$groupManager = $server->query(GroupManager::class);
 				$isAdmin = $groupManager->isAdmin($user->getUID());
 				$isSubAdmin = $groupManager->getSubAdmin()->isSubAdmin($user);
 			}

diff --git a/apps/settings/lib/Controller/ChangePasswordController.php b/apps/settings/lib/Controller/ChangePasswordController.php
@@ -35,6 +35,7 @@
 
 namespace OCA\Settings\Controller;
 
+use OC\Group\Manager as GroupManager;
 use OC\HintException;
 use OC\User\Session;
 use OCP\App\IAppManager;
@@ -58,10 +59,7 @@ class ChangePasswordController extends Controller {
 	/** @var IL10N */
 	private $l;
 
-	/**
-	 * @var IGroupManager
-	 * @phan-var \OC\Group\Manager
-	 */
+	/** @var GroupManager */
 	private $groupManager;
 
 	/** @var Session */
@@ -75,7 +73,7 @@ public function __construct(string $appName,
 								string $userId,
 								IUserManager $userManager,
 								IUserSession $userSession,
-								IGroupManager $groupManager,
+								GroupManager $groupManager,
 								IAppManager $appManager,
 								IL10N $l) {
 		parent::__construct($appName, $request);