Don't use SELECT DISTINCT when to_char() is used in a WHERE statement

Nice bug in Oracle Signed-off-by: Joas Schilling <[email protected]>
nextcloud · Sep 7, 2020 · a8bd209 · a8bd209
1 parent 16e1d1c
commit a8bd209
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/apps/workflowengine/lib/Manager.php b/apps/workflowengine/lib/Manager.php
@@ -147,10 +147,10 @@ public function getRuleMatcher(): IRuleMatcher {
 	public function getAllConfiguredEvents() {
 		$query = $this->connection->getQueryBuilder();
 
-		$query->selectDistinct('class')
-			->addSelect('entity', 'events')
+		$query->select('class', 'entity', 'events')
 			->from('flow_operations')
-			->where($query->expr()->neq('events', $query->createNamedParameter('[]'), IQueryBuilder::PARAM_STR));
+			->where($query->expr()->neq('events', $query->createNamedParameter('[]'), IQueryBuilder::PARAM_STR))
+			->groupBy('class', 'entity', 'events');
 
 		$result = $query->execute();
 		$operations = [];