Merge pull request #22883 from nextcloud/techdebt/noid/remove-phan

Remove phan config - was replaced by Psalm

.drone.yml

@@ -43,31 +43,6 @@ trigger:
     - pull_request
     - push
 
-#---
-#kind: pipeline
-#name: syntax-and-phan
-#
-#steps:
-#- name: submodules
-#  image: docker:git
-#  commands:
-#    - git submodule update --init
-#- name: phan
-#  image: nextcloudci/php7.2:php7.2-13
-#  commands:
-#    - composer install
-#    - composer require --dev "phan/phan:0.11.1"
-#    - ./lib/composer/phan/phan/phan -k build/.phan/config.php
-#    - php ./build/.phan/plugin-checker.php
-#
-#trigger:
-#  branch:
-#    - master
-#    - stable*
-#  event:
-#    - pull_request
-#    - push
-
 ---
 kind: pipeline
 name: litmus

apps/dav/lib/CalDAV/CalDavBackend.php

@@ -742,7 +742,6 @@ public function getSubscriptionById($subscriptionId) {
 	 * @param string $calendarUri
 	 * @param array $properties
 	 * @return int
-	 * @suppress SqlInjectionChecker
 	 */
 	public function createCalendar($principalUri, $calendarUri, array $properties) {
 		$values = [
@@ -818,9 +817,6 @@ public function updateCalendar($calendarId, PropPatch $propPatch) {
 		$supportedProperties = array_keys($this->propertyMap);
 		$supportedProperties[] = '{' . Plugin::NS_CALDAV . '}schedule-calendar-transp';
 
-		/**
-		 * @suppress SqlInjectionChecker
-		 */
 		$propPatch->handle($supportedProperties, function ($mutations) use ($calendarId) {
 			$newValues = [];
 			foreach ($mutations as $propertyName => $propertyValue) {
@@ -2148,9 +2144,6 @@ public function updateSubscription($subscriptionId, PropPatch $propPatch) {
 		$supportedProperties = array_keys($this->subscriptionPropertyMap);
 		$supportedProperties[] = '{http://calendarserver.org/ns/}source';
 
-		/**
-		 * @suppress SqlInjectionChecker
-		 */
 		$propPatch->handle($supportedProperties, function ($mutations) use ($subscriptionId) {
 			$newValues = [];
 

apps/dav/lib/CalDAV/Reminder/NotificationProvider/EmailProvider.php

@@ -381,9 +381,7 @@ private function generateDateString(IL10N $l10n, VEvent $vevent):string {
 
 		$diff = $dtstartDt->diff($dtendDt);
 
-		/** @phan-suppress-next-line PhanUndeclaredClassMethod */
 		$dtstartDt = new \DateTime($dtstartDt->format(\DateTime::ATOM));
-		/** @phan-suppress-next-line PhanUndeclaredClassMethod */
 		$dtendDt = new \DateTime($dtendDt->format(\DateTime::ATOM));
 
 		if ($isAllDay) {
@@ -400,9 +398,7 @@ private function generateDateString(IL10N $l10n, VEvent $vevent):string {
 
 		$startTimezone = $endTimezone = null;
 		if (!$vevent->DTSTART->isFloating()) {
-			/** @phan-suppress-next-line PhanUndeclaredClassMethod */
 			$startTimezone = $vevent->DTSTART->getDateTime()->getTimezone()->getName();
-			/** @phan-suppress-next-line PhanUndeclaredClassMethod */
 			$endTimezone = $this->getDTEndFromEvent($vevent)->getDateTime()->getTimezone()->getName();
 		}
 

apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php

@@ -138,15 +138,11 @@ protected function extractEventDetails(VEvent $vevent):array {
 				? ((string) $vevent->LOCATION)
 				: null,
 			'all_day' => $start instanceof Property\ICalendar\Date,
-			/** @phan-suppress-next-line PhanUndeclaredClassMethod */
 			'start_atom' => $start->getDateTime()->format(\DateTime::ATOM),
 			'start_is_floating' => $start->isFloating(),
-			/** @phan-suppress-next-line PhanUndeclaredClassMethod */
 			'start_timezone' => $start->getDateTime()->getTimezone()->getName(),
-			/** @phan-suppress-next-line PhanUndeclaredClassMethod */
 			'end_atom' => $end->getDateTime()->format(\DateTime::ATOM),
 			'end_is_floating' => $end->isFloating(),
-			/** @phan-suppress-next-line PhanUndeclaredClassMethod */
 			'end_timezone' => $end->getDateTime()->getTimezone()->getName(),
 		];
 	}

apps/dav/lib/CardDAV/CardDavBackend.php

@@ -374,9 +374,6 @@ public function updateAddressBook($addressBookId, \Sabre\DAV\PropPatch $propPatc
 			'{' . Plugin::NS_CARDDAV . '}addressbook-description',
 		];
 
-		/**
-		 * @suppress SqlInjectionChecker
-		 */
 		$propPatch->handle($supportedProperties, function ($mutations) use ($addressBookId) {
 			$updates = [];
 			foreach ($mutations as $property => $newValue) {

apps/files_external/lib/Service/DBConfigService.php

@@ -153,7 +153,6 @@ protected function modifyMountsOnDelete(string $applicableId, int $applicableTyp
 	 * Get admin defined mounts
 	 *
 	 * @return array
-	 * @suppress SqlInjectionChecker
 	 */
 	public function getAdminMounts() {
 		$builder = $this->connection->getQueryBuilder();
@@ -198,7 +197,6 @@ public function getMountsFor($type, $value) {
 	 * @param int $type any of the self::APPLICABLE_TYPE_ constants
 	 * @param string|null $value user_id, group_id or null for global mounts
 	 * @return array
-	 * @suppress SqlInjectionChecker
 	 */
 	public function getAdminMountsFor($type, $value) {
 		$builder = $this->connection->getQueryBuilder();
@@ -214,7 +212,6 @@ public function getAdminMountsFor($type, $value) {
 	 * @param int $type any of the self::APPLICABLE_TYPE_ constants
 	 * @param string[] $values user_ids or group_ids
 	 * @return array
-	 * @suppress SqlInjectionChecker
 	 */
 	public function getAdminMountsForMultiple($type, array $values) {
 		$builder = $this->connection->getQueryBuilder();
@@ -238,7 +235,6 @@ public function getAdminMountsForMultiple($type, array $values) {
 	 * @param int $type any of the self::APPLICABLE_TYPE_ constants
 	 * @param string|null $value user_id, group_id or null for global mounts
 	 * @return array
-	 * @suppress SqlInjectionChecker
 	 */
 	public function getUserMountsFor($type, $value) {
 		$builder = $this->connection->getQueryBuilder();