Lint and psalm fix

Signed-off-by: John Molakvoæ <[email protected]>
nextcloud · Apr 21, 2022 · a5c4ce3 · a5c4ce3
1 parent 63a664f
commit a5c4ce3
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 10 deletions.
diff --git a/apps/theming/lib/Controller/ThemingController.php b/apps/theming/lib/Controller/ThemingController.php
@@ -308,7 +308,7 @@ public function getImage(string $key, bool $useSvg = true) {
 	 * @NoSameSiteCookieRequired
 	 * @NoTwoFactorRequired
 	 *
-	 * @return FileDisplayResponse|NotFoundResponse
+	 * @return DataDisplayResponse|NotFoundResponse
 	 */
 	public function getThemeStylesheet(string $themeId, bool $plain = false, bool $withCustomCss = false) {
 		$themes = $this->themesService->getThemes();

diff --git a/apps/theming/lib/Service/ThemesService.php b/apps/theming/lib/Service/ThemesService.php
@@ -94,6 +94,7 @@ public function enableTheme(ITheme $theme): array {
 		});
 
 		// Retrieve IDs only
+		/** @var string[] */
 		$filteredThemesIds = array_map(function(ITheme $t) {
 			return $t->getId();
 		}, $filteredThemes);
@@ -136,6 +137,7 @@ public function isEnabled(ITheme $theme): bool {
 			$themes = $this->getEnabledThemes();
 			return in_array($theme->getId(), $themes);
 		}
+		return false;
 	}
 
 	/**

diff --git a/apps/theming/lib/Themes/DefaultTheme.php b/apps/theming/lib/Themes/DefaultTheme.php
@@ -35,6 +35,7 @@
 class DefaultTheme implements ITheme {
 	public Util $util;
 	public ThemingDefaults $themingDefaults;
+	public IURLGenerator $urlGenerator;
 	public ImageManager $imageManager;
 	public IConfig $config;
 	public IL10N $l;

diff --git a/apps/theming/lib/Util.php b/apps/theming/lib/Util.php
@@ -111,13 +111,13 @@ public function darken(string $color, int $factor): string {
 	 *
 	 * Copied from cssphp, copyright Leaf Corcoran, licensed under MIT
 	 *
-	 * @param integer $red
-	 * @param integer $green
-	 * @param integer $blue
+	 * @param int $red
+	 * @param int $green
+	 * @param int $blue
 	 *
-	 * @return array
+	 * @return float[]
 	 */
-	public function toHSL(string $red, string $green, string $blue): array {
+	public function toHSL(int $red, int $green, int $blue): array {
 		$color = new Color(Color::rgbToHex(['R' => $red, 'G' => $green, 'B' => $blue]));
 		return array_values($color->getHsl());
 	}

diff --git a/apps/theming/src/components/ItemPreview.vue b/apps/theming/src/components/ItemPreview.vue
@@ -15,7 +15,7 @@
 </template>
 
 <script>
-import { generateFilePath} from '@nextcloud/router'
+import { generateFilePath } from '@nextcloud/router'
 import CheckboxRadioSwitch from '@nextcloud/vue/dist/Components/CheckboxRadioSwitch'
 
 export default {

diff --git a/core/src/views/UnifiedSearch.vue b/core/src/views/UnifiedSearch.vue
@@ -86,12 +86,16 @@
 				<div v-else>
 					{{ t('core', 'Press enter to start searching') }}
 				</div>
-				<template #icon><Magnify /></template>
+				<template #icon>
+					<Magnify />
+				</template>
 			</EmptyContent>
 
 			<EmptyContent v-else-if="!isLoading || isShortQuery">
 				{{ t('core', 'Start typing to search') }}
-				<template #icon><Magnify /></template>
+				<template #icon>
+					<Magnify />
+				</template>
 				<template v-if="isShortQuery" #desc>
 					{{ n('core',
 						'Please enter {minSearchLength} character or more to search',

diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php
@@ -40,7 +40,9 @@
 		<?php emit_script_loading_tags($_); ?>
 		<?php print_unescaped($_['headers']); ?>
 	</head>
-	<body id="<?php p($_['bodyid']);?>" <?php foreach ($_['enabledThemes'] as $themeId) { p("data-theme-$themeId "); }?>>
+	<body id="<?php p($_['bodyid']);?>" <?php foreach ($_['enabledThemes'] as $themeId) {
+				p("data-theme-$themeId ");
+			}?>>
 	<?php include 'layout.noscript.warning.php'; ?>
 
 		<?php foreach ($_['initialStates'] as $app => $initialState) { ?>