Merge pull request #46091 from nextcloud/backport/46073/stable29

[stable29] fix: allows admin to edit global credentials
nextcloud · Jul 10, 2024 · 7c088bd · 7c088bd
2 parents db748b4 + a631733
commit 7c088bd
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/apps/files_external/lib/Controller/AjaxController.php b/apps/files_external/lib/Controller/AjaxController.php
@@ -106,15 +106,21 @@ public function getSshKeys($keyLength = 1024) {
 	 */
 	public function saveGlobalCredentials($uid, $user, $password) {
 		$currentUser = $this->userSession->getUser();
+		if ($currentUser === null) {
+			return false;
+		}
 
 		// Non-admins can only edit their own credentials
-		$allowedToEdit = ($currentUser->getUID() === $uid);
+		// Admin can edit global credentials
+		$allowedToEdit = $uid === ''
+			? $this->groupManager->isAdmin($currentUser->getUID())
+			: $currentUser->getUID() === $uid;
 
 		if ($allowedToEdit) {
 			$this->globalAuth->saveAuth($uid, $user, $password);
 			return true;
-		} else {
-			return false;
 		}
+
+		return false;
 	}
 }