Refactor "substr" calls to improve code readability

Signed-off-by: Hamid Dehnavi <[email protected]>
nextcloud · Jul 7, 2023 · 6526bab · 6526bab
1 parent 5640246
commit 6526bab
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/apps/files/lib/Service/OwnershipTransferService.php b/apps/files/lib/Service/OwnershipTransferService.php
@@ -447,7 +447,7 @@ private function transferIncomingShares(string $sourceUid,
 		$progress = new ProgressBar($output, count($sourceShares));
 		$prefix = "$destinationUid/files";
 		$finalShareTarget = '';
-		if (substr($finalTarget, 0, strlen($prefix)) === $prefix) {
+		if (str_starts_with($finalTarget, $prefix)) {
 			$finalShareTarget = substr($finalTarget, strlen($prefix));
 		}
 		foreach ($sourceShares as $share) {
@@ -457,7 +457,7 @@ private function transferIncomingShares(string $sourceUid,
 				if (trim($path, '/') !== '') {
 					$pathToCheck = '/' . trim($path) . '/';
 				}
-				if (substr($share->getTarget(), 0, strlen($pathToCheck)) !== $pathToCheck) {
+				if (!str_starts_with($share->getTarget(), $pathToCheck)) {
 					continue;
 				}
 				$shareTarget = $share->getTarget();