Merge pull request #46364 from nextcloud/backport/46321/stable28

[stable28] fix(SharingDetailsView): Prevent illegal unselection of read permissions
nextcloud · Jul 9, 2024 · 19ab1ff · 19ab1ff
2 parents 2595e48 + 710287f
commit 19ab1ff
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 7 deletions.
diff --git a/apps/files_sharing/src/views/SharingDetailsTab.vue b/apps/files_sharing/src/views/SharingDetailsTab.vue
@@ -566,6 +566,9 @@ export default {
 			// allowed to revoke it too (but not to grant it again).
 			return (this.fileInfo.canDownload() || this.canDownload)
 		},
+		canRemoveReadPermission() {
+			return this.allowsFileDrop && this.share.type === this.SHARE_TYPES.SHARE_TYPE_LINK
+		},
 		// if newPassword exists, but is empty, it means
 		// the user deleted the original password
 		hasUnsavedPassword() {
@@ -774,6 +777,10 @@ export default {
 					this.setCustomPermissions = true
 				}
 			}
+			// Read permission required for share creation
+			if (!this.canRemoveReadPermission) {
+				this.hasRead = true
+			}
 		},
 		handleCustomPermissions() {
 			if (!this.isNewShare && (this.hasCustomPermissions || this.share.setCustomPermissions)) {

diff --git a/dist/7144-7144.js b/dist/7144-7144.js
diff --git a/dist/7822-7822.js.LICENSE.txt → dist/7144-7144.js.LICENSE.txt b/dist/7822-7822.js.LICENSE.txt → dist/7144-7144.js.LICENSE.txt
diff --git a/dist/7144-7144.js.map b/dist/7144-7144.js.map
diff --git a/dist/7822-7822.js b/dist/7822-7822.js
diff --git a/dist/7822-7822.js.map b/dist/7822-7822.js.map
diff --git a/dist/files_sharing-files_sharing_tab.js b/dist/files_sharing-files_sharing_tab.js
diff --git a/dist/files_sharing-files_sharing_tab.js.map b/dist/files_sharing-files_sharing_tab.js.map