Merge pull request #38153 from nextcloud/backport/38125/stable26

[stable26] Check if version entity is not null before delete
nextcloud · May 10, 2023 · 1229beb · 1229beb
2 parents 7083668 + 07b82d7
commit 1229beb
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/apps/files_versions/lib/Storage.php b/apps/files_versions/lib/Storage.php
@@ -608,7 +608,12 @@ public static function expireOlderThanMaxForUser($uid) {
 		foreach ($versions as $version) {
 			$internalPath = $version->getInternalPath();
 			\OC_Hook::emit('\OCP\Versions', 'preDelete', ['path' => $internalPath, 'trigger' => self::DELETE_TRIGGER_RETENTION_CONSTRAINT]);
-			$versionsMapper->delete($versionEntities[$version->getId()]);
+
+			$versionEntity = $versionEntities[$version->getId()];
+			if (!is_null($versionEntity)) {
+				$versionsMapper->delete($versionEntity);
+			}
+
 			$version->delete();
 			\OC_Hook::emit('\OCP\Versions', 'delete', ['path' => $internalPath, 'trigger' => self::DELETE_TRIGGER_RETENTION_CONSTRAINT]);
 		}