-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly check for a set guest name when obtaining the file #805
Conversation
Signed-off-by: Julius Härtl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
This currently brings in other issues :/ Needs more investigation
Signed-off-by: Julius Härtl <[email protected]>
…btaining the file as well Signed-off-by: Julius Härtl <[email protected]>
@rullzer I pushed two more commits, as with the earlier fix, the filesystem was actually setup for the owner instead of the editor which caused the I think for a code cleanup we could try moving the whole Wopi token handling for which user is acting in the anonymous request to a middleware to make sure the preconditions are properly set for all WopiController methods. I'll look into that in a follow up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes tested. This has resolved the saving issues in #780. tests involved individual edits and saves to same file with users editing and exiting the document. Then saves where tested on the fly with users editing at the same time. Both worked without error on this commit.
yes. That would make a lot of sense indeed. |
To reproduce, put a file on external storage and share it with another user that doesn't have access to the external storage. This makes sure that the editor is not falsely overwritten with the owner.