fix(sharing): use correct save path when renaming #4378
Merged
+49
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elizabeth Danzberger <[email protected]>
|
/backport to stable30 |
JuliaKirschenheuter
approved these changes
Jan 9, 2025
|
Looks good, thanks for also extending the test cases 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When accessing a publicly shared folder as a logged-in user with edit permissions and attempting to rename a file from within Collabora, the file would seemingly disappear upon a page refresh. It was actually being saved to the owner's root folder (so not entirely disappearing, just being moved out of the shared folder).
It seems to have been caused by a previous pull request which introduced logic to determine the proper save path for a file. We instead just use the file path now if it is a request for a name change, instead of doing some unneeded checks for public shares, etc.
Checklist