Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv6 handling in WOPI allow list #2696

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Conversation

juliusknorr
Copy link
Member

  • fix(wopi): Properly handle single IPv6 addresses in WOPI allow list
  • refactor(wopi): Use symfony/http-foundation util to match ip addresses

Refactoring is kept separate so we can backport the fix to older releases since symfony/http-foundation is only available since 25: nextcloud/3rdparty#1102

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr
Copy link
Member Author

juliusknorr commented Jan 2, 2023

ping for review

Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Tests included... yay!

@juliusknorr juliusknorr merged commit d47ac0a into master Jan 2, 2023
@juliusknorr juliusknorr deleted the bugfix/allow-list-ipv6 branch January 2, 2023 11:40
@juliusknorr
Copy link
Member Author

/backport 016c3ac to stable25

@juliusknorr
Copy link
Member Author

/backport 016c3ac to stable24

@juliusknorr
Copy link
Member Author

/backport 016c3ac to stable23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants