Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rtf and txt as supported file formats #11

Merged
merged 5 commits into from
Mar 20, 2017
Merged

add rtf and txt as supported file formats #11

merged 5 commits into from
Mar 20, 2017

Conversation

timar
Copy link
Member

@timar timar commented Jan 7, 2017

Fix for #10

@timar
Copy link
Member Author

timar commented Jan 18, 2017

Fix for #16

@timar timar requested a review from LukasReschke January 18, 2017 09:15
@timar
Copy link
Member Author

timar commented Mar 14, 2017

Analysing /home/travis/build/nextcloud/server/apps/richdocuments/lib/Controller/DocumentController.php
 1 errors
    line  225: OC_Helper - Static method of private class must not be called
Analysing /home/travis/build/nextcloud/server/apps/richdocuments/appinfo/app.php
 1 errors
    line   44: OC_Helper - Static method of private class must not be called
App is not compliant

These errors were not introduced by my patches, and I don't know how to fix them, if it is possible at all, and this pull request has been blocked for two months because of this. It is quite discouraging.

@LukasReschke can you please move this forward?

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely happy about this because for TXT we already do have a standard viewer for example but this seems fair enough. Might warrant in the server to offer some "With what app do you want to open it" in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants