Merge pull request #4102 from nextcloud/debug/mention

fix: Add proper messages to mention response
nextcloud · Dec 2, 2024 · d759323 · d759323
2 parents 78a57ac + 2f15d03
commit d759323
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/Controller/MentionController.php b/lib/Controller/MentionController.php
@@ -38,7 +38,7 @@ public function mention(int $fileId, string $mention): DataResponse {
 		$userFolder = $this->rootFolder->getUserFolder($this->userId);
 		$file = $userFolder->getFirstNodeById($fileId);
 		if ($file === null) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
+			return new DataResponse(['message' => 'File not found for current user'], Http::STATUS_NOT_FOUND);
 		}
 
 		// Reverse the array of users to pop off the first user later
@@ -52,7 +52,7 @@ public function mention(int $fileId, string $mention): DataResponse {
 		$userFolder = $this->rootFolder->getUserFolder($user->getUID());
 		$file = $userFolder->getFirstNodeById($fileId);
 		if ($file === null) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
+			return new DataResponse(['message' => 'File not found for mentioned user'], Http::STATUS_NOT_FOUND);
 		}
 
 		$notification = $this->manager->createNotification();
@@ -70,6 +70,6 @@ public function mention(int $fileId, string $mention): DataResponse {
 			return new DataResponse([], Http::STATUS_OK);
 		}
 
-		return new DataResponse([], Http::STATUS_NOT_FOUND);
+		return new DataResponse(['message' => 'Notification already present'], Http::STATUS_NOT_FOUND);
 	}
 }