Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch index to ocs #829

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

switch index to ocs #829

wants to merge 2 commits into from

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Dec 12, 2024

Fix #828

  • webfrontend generates url with "index.php" and thus does not work.

@ChristophWurst ChristophWurst requested a review from Pytal December 12, 2024 07:47
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @tobiasKaminsky,
Thank you very much for the contribution.

This seems to convert the internal API of the app to a public API. To meet the standards of a public API, there has to be documentation about it in the developer documentation of Nextcloud. There are two options for an OCS documentation

  1. Manually document the endpoints.
  2. Use the OpenAPI generator to auto-generate a machine-readable metadata file.

Please note that once the API is public, it can no longer change in breaking ways for one year.

@ChristophWurst
Copy link
Member

Please also see #458. I think the two PRs have the same goal.

src/service/RecommendationService.js Outdated Show resolved Hide resolved
src/service/RecommendationService.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have index route available for client via OCS
3 participants