Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[stable28] Fix npm audit" #1154

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Dec 11, 2024

Reverts #1104

Was merged too early, in RC1 phase before 28.0.14

@Pytal
Copy link
Member

Pytal commented Dec 11, 2024

🙈 any idea why the block workflow was green?

@blizzz
Copy link
Member Author

blizzz commented Dec 12, 2024

🙈 any idea why the block workflow was green?

No worries. The last commit/push was from Dec 8, if I see it correctly, back then the RC 1 was not merged yet, so the block action was green. Race condition, no worries.

@blizzz blizzz merged commit e380373 into stable28 Dec 12, 2024
36 of 39 checks passed
@blizzz blizzz deleted the revert-1104-automated/noid/stable28-fix-npm-audit branch December 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants