Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize PHP code, replace deprecated code #45

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Modernize PHP code, replace deprecated code #45

merged 2 commits into from
Jun 14, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 14, 2023

Follow up on #39

Info: This looks huge but basically this is from running psalm and cs:fix.

Changes:

  • Update coding style and run cs:fix
  • Add psalm config / psalm / psalm CI workflow and run psalm to auto fix docblock issues
  • Replace deprecated ILogger with the PSR logger interface
  • Migrate from Hooks to Events (see LoginHook ➡️ LoginListener)
  • Use public API instead of private where possible (OCP vs OC).

susnux added 2 commits June 14, 2023 15:05
@susnux
fix: Cleanup and modernize php code
f0d624c 
* Modernize Application registration code
* Listen on events rather than deprecated hooks
* Drop usage of deprecated `ILogger` and use PSR logger instead
* Move from `OC\BackgroundJob\TimedJob` to `OCP\BackgroundJob\TimedJob`
* Cleanup code issues detected by psalm

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
feat: Add psalm scripts and CI workflow
8f71057 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux added enhancement New feature or request 3. to review labels Jun 14, 2023
@susnux susnux requested a review from skjnldsv June 14, 2023 13:30
skjnldsv
skjnldsv approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn!! 😍

@skjnldsv skjnldsv merged commit c985ff9 into main Jun 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/modernize branch June 14, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @skjnldsv