[stable6] Perf improvements for stable-6 for 26 branch #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
reviewed
Apr 24, 2024
artonge
force-pushed
the
fix/stable-6-for-26-perf-improvements
branch
from
07d8023
to
68439a5
Compare
artonge
force-pushed
the
stable-6-for-26
branch
from
d67641c
to
112afd5
Compare
artonge
force-pushed
the
stable-6-for-26
branch
from
112afd5
to
9f26d1f
Compare
Saves a few DB requests Signed-off-by: Côme Chilliet <[email protected]>
Avoid a DB request for each poll, instead use the data we just got from the full list. Signed-off-by: Côme Chilliet <[email protected]>
Not pretty but avoids a few DB calls. Ideally we should not do these requests at all, I do not really understand this share part in Acl. Signed-off-by: Côme Chilliet <[email protected]>
artonge
force-pushed
the
fix/stable-6-for-26-perf-improvements
branch
from
549f6e0
to
8bf95e8
Compare
artonge
approved these changes
Apr 24, 2024
delete-merged-branch
bot
deleted the
fix/stable-6-for-26-perf-improvements
branch
artonge
changed the title
1 task
|
/backport to master |
2 tasks
@artonge Never ever!!!! |
Is the code base that different? We should make sure master does not suffer from the perf problems this PR fixed for 6, otherwise upgrading from 6 to 7 would result in performance degradation. I did not look into the details, maybe those extra DB requests are already gone in 7. |
Existing problems have to be solved another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to bring the number of DB requests for polls listing down.
So far got down from 52 to 30 for 4 polls with no votes.