Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix l10n #774

Merged
merged 1 commit into from
May 26, 2021
Merged

Fix l10n #774

merged 1 commit into from
May 26, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented May 25, 2021 •
edited
Loading

Fix #708

image

@Pytal Pytal requested a review from skjnldsv May 25, 2021 18:46
@Pytal Pytal force-pushed the fix/l10n branch 2 times, most recently from 781ecc3 to 0b7ef1e Compare May 25, 2021 19:12
@Pytal Pytal added the 3. to review Waiting for reviews label May 25, 2021
@Pytal Pytal self-assigned this May 25, 2021
skjnldsv
skjnldsv approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the "moment": "^2.29.1" dependency can also go? :)

@Pytal
Copy link
Member Author

Pytal commented May 26, 2021

I guess the "moment": "^2.29.1" dependency can also go? :)

Good call!

@Pytal Pytal force-pushed the fix/l10n branch 4 times, most recently from 37fc405 to 77e6af8 Compare May 26, 2021 15:12
@Pytal
Fix l10n
4742ad7 
Signed-off-by: Christopher Ng <[email protected]>

Remove moment dependency

Signed-off-by: Christopher Ng <[email protected]>

Compile

Signed-off-by: Christopher Ng <[email protected]>

Recompile

Signed-off-by: Christopher Ng <[email protected]>

Recompile

Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal merged commit 9f80f3b into master May 26, 2021
@Pytal Pytal deleted the fix/l10n branch May 26, 2021 20:10
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 26, 2021
@Pytal Pytal added this to the Nextcloud 22 milestone May 26, 2021
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

l10n: Month names
2 participants
@Pytal @skjnldsv