enh: Migrate from custom webdav v4 handling to webdav v5 with @nextcloud/files
#2312
Conversation
susnux
force-pushed
the
enh/migrate-to-webdav-v5
branch
from
8731f8a to
d2509b7
Compare
|
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
susnux
force-pushed
the
enh/migrate-to-webdav-v5
branch
from
d2509b7 to
0bacc16
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
enh/migrate-to-webdav-v5
branch
from
0bacc16 to
b33af7d
Compare
|
@artonge I resolved the conflicts and merged in your suggestions, seems to work fine (did some testing). |
| export default `<?xml version="1.0"?> | ||
| import { getDavProperties, registerDavProperty } from '@nextcloud/files' | ||
|
|
||
| const recoginzeDAVProps = [ |
There was a problem hiding this comment.
| const recoginzeDAVProps = [ | |
| const recognizeDAVProps = [ |
| */ | ||
| export const getDefaultDavProps = () => { | ||
| if (props === null) { | ||
| recoginzeDAVProps.forEach(prop => registerDavProperty(prop)) |
There was a problem hiding this comment.
Why not register them on load?
There was a problem hiding this comment.
Or maybe they should be passed in extraProps if they are recognize only
| <d:order> | ||
| <d:prop><nc:metadata-photos-original_date_time/></d:prop> | ||
| <d:descending/> | ||
| </d:order> |
| 'nc:metadata-photos-size', | ||
| 'nc:metadata-files-live-photo', | ||
| 'nc:metadata-blurhash', | ||
| 'nc:metadata-photos-original_date_time', |
There was a problem hiding this comment.
Those are not bound to the sidebar, shouldn't we register them in main.js instead ?
| console.error('Failed to get tag content', id, error.response) | ||
| logger.error(`Failed to get tag content, id: ${id}`, { error }) | ||
| } else { | ||
| logger.debug(error) |
There was a problem hiding this comment.
Still an error, no?
| logger.debug(error) | |
| logger.error(error) |
| "allowSyntheticDefaultImports": true, | ||
| "moduleResolution": "node", | ||
| "moduleResolution": "Bundler", |
There was a problem hiding this comment.
IIRC, the Cypress error might be due to this change.
| @@ -51,6 +52,12 @@ export default new Store({ | |||
|
|
|||
| plugins: [ | |||
| (store) => { | |||
| // Initialize the `photosLocationFolder` state | |||
| getFolder(store.state.userConfig.photosLocation) | |||
There was a problem hiding this comment.
Isn't this doing the same thing twice?
Lets use webdav v5 and helpers from
@nextcloud/filesinstead of old webdav v4 with custom patching.