Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Fix description for favorite images and remove image description #2275

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix(files): Fix description for favorite images and remove image description #2275

merged 2 commits into from
Jan 23, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 23, 2024 •
edited
Loading

Fixes nextcloud/server#41900

  • Remove image description because it was just a duplicate of image name (Screen reader will just read everything: content of aria-label, alt and aria-describedby and all this information is more or less the same), like:
  1. Open the full size "Screenshot from 2024-01-03 18-51-21.png" image
  2. Screenshot from 2024-01-03 18-51-21.png
  3. Screenshot from 2024-01-03 18-51-21.png
  • Add information to the link if an image is a favorite one

No visual changes

🏚️ Before 🏡 After
image Screenshot from 2024-01-23 11-24-13

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jan 23, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 23, 2024
emoral435
emoral435 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks aside, LGTM!

src/components/File.vue Outdated Show resolved Hide resolved
@emoral435 emoral435 added enhancement New feature or request accessibility labels Jan 23, 2024
@emoral435 emoral435 added this to the Nextcloud 28.0.3 milestone Jan 23, 2024
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41900-fix-description-for-favorite-images branch from a89f9fd to 7ed7001 Compare January 23, 2024 13:19
@susnux
Copy link
Contributor

susnux commented Jan 23, 2024

/compile

@susnux
Copy link
Contributor

susnux commented Jan 23, 2024

/backport 7ed7001 to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 23, 2024
@nextcloud-command
chore(assets): Recompile assets
6360bda 
Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit b37af9e into master Jan 23, 2024
24 checks passed
@susnux susnux deleted the fix/41900-fix-description-for-favorite-images branch January 23, 2024 17:42
@backportbot backportbot bot mentioned this pull request Jan 23, 2024
Merged
1 task
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews accessibility enhancement New feature or request feedback-requested
Projects
None yet
Milestone
Nextcloud 28.0.3
4 participants
@JuliaKirschenheuter @susnux @emoral435 @nextcloud-command