Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the color-primary-element* variables #1794

Merged
merged 1 commit into from
May 15, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 12, 2023

Explanation: the color-primary variables are not to be used in components because the introduce problems with high-contrast primary colors. Fix this by using the primary-element variables instead.

@szaimen szaimen added bug Something isn't working 3. to review Waiting for reviews design Related to the design labels May 12, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 12, 2023
@szaimen szaimen requested review from marcelklehr and artonge May 12, 2023 14:22
@artonge
Copy link
Collaborator

artonge commented May 15, 2023

/rebase

@nextcloud-command nextcloud-command force-pushed the enh/noid/use-primary-element branch from 902b890 to 5c0658a Compare May 15, 2023 10:05
@artonge
Copy link
Collaborator

artonge commented May 15, 2023

/compile amend /

@artonge artonge enabled auto-merge May 15, 2023 10:14
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the enh/noid/use-primary-element branch from 5c0658a to 81521e2 Compare May 15, 2023 13:22
@artonge artonge merged commit 57b8502 into master May 15, 2023
@artonge artonge deleted the enh/noid/use-primary-element branch May 15, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants