-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable26] Fix #1753: Media and Photos views are blank after upgrade to 26.0.1 #1759
Conversation
/compile amend / |
Handle empty fileMetadataSize. Signed-off-by: umgfoin <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
5e1823b
to
8a83660
Compare
Can anyone help me on how I can fix this on my personal installation as I mainly use nextcloud as an alternative to google photos hence this bug has made my instance totally useless as I can't see any of my photos. Or can anyone provide the details of when can we expect an update with fix to this bug. I apologise if this isn't the correct place to ask these type of questions as I am new to GitHub and still familiarising myself with it. |
The fix will be available in v26.0.2. You can refer to the release schedule for a release date: https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule |
No way to release an update of the Photos app before the 26.0.2 availability? |
If this really is a regression in 26.0.1, it sounds like quite a significant core functionality issue --- Photos app is basically unusable. In my view, a fix should be delivered much faster than having to wait until next scheduled minor version, which is a month later, especially if the fix is already available. We're told to upgrade to minor versions as "nothing should break", and the purpose is to get security updates and bug fixes. |
I second this, waiting one month for a fix that has been introduced by a security update is quite unfortunate :( |
To patch now. Download each of the Photo .js,.map files in the MR and overwrite the copy in your self-hosted instance e.g. /data/app/apps/photos/js Don't forget to force a browser refresh (CTRL+F5) |
Can I just download that folder and paste it in my self-hosted instance. Will that cause any problems? |
I just replaced my whole js folder contents from, I'll have to figure out how to get it properly refreshed in Chrome. |
You need to clear the cache of your browser. Thanks man I was going through the net for an hour thinking if I did anything wrong while replacing the folder but this didn't occur to me to check in incognito mode or in other browser. |
Yes, that's what I did, it's just having to remember how to do it, each browser handling it different. I did finally do it since posting and it seems to be working as expected on both browsers now. |
Replacing the js-folder fixes the "All media" and "Photos" views, but now breaks "Folder" view. |
I'd never used folder view in the past, so didn't think to check, but I can confirm Folder View in Photos does not work for me either. |
same here |
Folder view might be fixed by #1779 |
I can confirm, its working, if you replace the whole "js" folder and force-reload with "Strg+F5/Ctrl+F5". Thanks! |
fixed in version 26.0.2 |
backport of #1757