Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] Fix #1753: Media and Photos views are blank after upgrade to 26.0.1 #1759

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Apr 24, 2023

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #1757

@artonge
Copy link
Collaborator

artonge commented Apr 24, 2023

/compile amend /

Handle empty fileMetadataSize.

Signed-off-by: umgfoin <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge marked this pull request as ready for review April 24, 2023 08:26
@artonge artonge enabled auto-merge April 24, 2023 08:26
@artonge artonge merged commit 62727e9 into stable26 Apr 24, 2023
@artonge artonge deleted the backport/1757/stable26 branch April 24, 2023 08:26
@Jayvratsinh
Copy link

Can anyone help me on how I can fix this on my personal installation as I mainly use nextcloud as an alternative to google photos hence this bug has made my instance totally useless as I can't see any of my photos. Or can anyone provide the details of when can we expect an update with fix to this bug. I apologise if this isn't the correct place to ask these type of questions as I am new to GitHub and still familiarising myself with it.

@artonge
Copy link
Collaborator

artonge commented Apr 27, 2023

The fix will be available in v26.0.2. You can refer to the release schedule for a release date: https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule

@marcello-lodi
Copy link

No way to release an update of the Photos app before the 26.0.2 availability?

@adimol
Copy link

adimol commented Apr 29, 2023

If this really is a regression in 26.0.1, it sounds like quite a significant core functionality issue --- Photos app is basically unusable. In my view, a fix should be delivered much faster than having to wait until next scheduled minor version, which is a month later, especially if the fix is already available.

We're told to upgrade to minor versions as "nothing should break", and the purpose is to get security updates and bug fixes.

@Sir-Photch
Copy link

I second this, waiting one month for a fix that has been introduced by a security update is quite unfortunate :(

@olivervinn
Copy link

To patch now.

Download each of the Photo .js,.map files in the MR and overwrite the copy in your self-hosted instance e.g. /data/app/apps/photos/js

Don't forget to force a browser refresh (CTRL+F5)

@Jayvratsinh
Copy link

Can I just download that folder and paste it in my self-hosted instance. Will that cause any problems?

@tincanfury
Copy link

To patch now.

Download each of the Photo .js,.map files in the MR and overwrite the copy in your self-hosted instance e.g. /data/app/apps/photos/js

Don't forget to force a browser refresh (CTRL+F5)

I just replaced my whole js folder contents from,
https://github.com/nextcloud/photos/tree/master/js
and while reloading on my normal browser it's not working, when I logged in via a browser I haven't logged into this nextcloud site from before it is now working fine.

I'll have to figure out how to get it properly refreshed in Chrome.

@Jayvratsinh
Copy link

Jayvratsinh commented May 3, 2023

To patch now.
Download each of the Photo .js,.map files in the MR and overwrite the copy in your self-hosted instance e.g. /data/app/apps/photos/js
Don't forget to force a browser refresh (CTRL+F5)

I just replaced my whole js folder contents from, https://github.com/nextcloud/photos/tree/master/js and while reloading on my normal browser it's not working, when I logged in via a browser I haven't logged into this nextcloud site from before it is now working fine.

I'll have to figure out how to get it properly refreshed in Chrome.

You need to clear the cache of your browser. Thanks man I was going through the net for an hour thinking if I did anything wrong while replacing the folder but this didn't occur to me to check in incognito mode or in other browser.

@tincanfury
Copy link

You need to clear the cache of your browser. Thanks man I was going through the net for an hour thinking if I did anything wrong while replacing the folder but this didn't occur to me to check in incognito mode or in other browser.

Yes, that's what I did, it's just having to remember how to do it, each browser handling it different. I did finally do it since posting and it seems to be working as expected on both browsers now.

@DaleBCooper
Copy link

Replacing the js-folder fixes the "All media" and "Photos" views, but now breaks "Folder" view.
Same on another test installation with 27.0.0 beta1.

@tincanfury
Copy link

Replacing the js-folder fixes the "All media" and "Photos" views, but now breaks "Folder" view.
Same on another test installation with 27.0.0 beta1.

I'd never used folder view in the past, so didn't think to check, but I can confirm Folder View in Photos does not work for me either.

@tknaller
Copy link

tknaller commented May 9, 2023

same here

@artonge
Copy link
Collaborator

artonge commented May 9, 2023

Folder view might be fixed by #1779

@artonge artonge mentioned this pull request May 9, 2023
1 task
@SKB-CGN
Copy link

SKB-CGN commented May 24, 2023

I can confirm, its working, if you replace the whole "js" folder and force-reload with "Strg+F5/Ctrl+F5".

Thanks!

@Draco-Zero
Copy link

fixed in version 26.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.